[dynamo] Guard on HAS_GRAPH_BREAKS if graph breaks are present (i.e. cache miss if compiled object requires nopython)#114073
Closed
jon-chuang wants to merge 6 commits intopytorch:mainfrom
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114073
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 95d886f with merge base 5a96a42 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This comment was marked as outdated.
This comment was marked as outdated.
…uang/nopython-guard
Collaborator
Author
Let's not handle this; it's last-mile and easy to get wrong; and also possibly incorrect to handle that way. |
NO_GRAPH_BREAKS if graph breaks are present (i.e. cache miss if compiled object requires nopython)
NO_GRAPH_BREAKS if graph breaks are present (i.e. cache miss if compiled object requires nopython)HAS_GRAPH_BREAKS if graph breaks are present (i.e. cache miss if compiled object requires nopython)
ezyang
approved these changes
Nov 20, 2023
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
davidberard98
added a commit
that referenced
this pull request
Dec 8, 2023
…S` if graph breaks are present (i.e. cache miss if compiled object requires nopython) (#114073)"" This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) [ghstack-poisoned]
davidberard98
added a commit
that referenced
this pull request
Dec 8, 2023
…ks are present (i.e. cache miss if compiled object requires nopython) (#114073)"" This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2023
…ent (i.e. cache miss if compiled object requires nopython) (#114073)" (#115384) This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) Pull Request resolved: #115384 Approved by: https://github.com/malfet
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…ent (i.e. cache miss if compiled object requires nopython) (pytorch#114073)" (pytorch#115384) This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) Pull Request resolved: pytorch#115384 Approved by: https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114059
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng