Skip to content

[dynamo] remove unused OptimizeCtx field - export#113901

Closed
jon-chuang wants to merge 7 commits intogh/jon-chuang/39/basefrom
gh/jon-chuang/39/head
Closed

[dynamo] remove unused OptimizeCtx field - export#113901
jon-chuang wants to merge 7 commits intogh/jon-chuang/39/basefrom
gh/jon-chuang/39/head

Conversation

@jon-chuang
Copy link
Collaborator

@jon-chuang jon-chuang commented Nov 16, 2023 •
edited
Loading

@jon-chuang
remove unused - export field
65b5948 
[ghstack-poisoned]
@jon-chuang jon-chuang mentioned this pull request Nov 16, 2023
Closed
4 tasks
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113901

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b3ae64f with merge base 0ea126e (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jon-chuang jon-chuang mentioned this pull request Nov 16, 2023
Closed
@jon-chuang jon-chuang changed the title remove unused - export field [dynamo] remove unused OptimizeCtx field - export Nov 16, 2023
@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
1371d8d 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jon-chuang jon-chuang mentioned this pull request Nov 17, 2023
Closed
@jon-chuang jon-chuang requested a review from ezyang November 17, 2023 03:57
@ezyang
Copy link
Contributor

ezyang commented Nov 17, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
9122ecb 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jon-chuang jon-chuang mentioned this pull request Nov 17, 2023
Closed
@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Nov 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
a030df6 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
4a88fd3 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
f45e7fa 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Nov 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jon-chuang
Update on "[dynamo] remove unused OptimizeCtx field - export"
b3ae64f 
This is only an internal API, so it's not really a BC breaking concern

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
@jon-chuang
Copy link
Collaborator Author

jon-chuang commented Nov 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 17, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2023
@jon-chuang @pytorchmergebot
[dynamo] promote skipfiles logging to verbose (#113916)
a5e4d4f 
Pull Request resolved: #113916
Approved by: https://github.com/ezyang
ghstack dependencies: #111299, #111300, #113901
pytorchmergebot pushed a commit that referenced this pull request Nov 17, 2023
@jon-chuang @pytorchmergebot
[utils] move config_typing.pyi to torch.utils (#113929)
00b6719 
Pull Request resolved: #113929
Approved by: https://github.com/ezyang, https://github.com/jansel
ghstack dependencies: #111299, #111300, #113901, #113916
@facebook-github-bot facebook-github-bot deleted the gh/jon-chuang/39/head branch November 20, 2023 15:28
davidberard98 added a commit that referenced this pull request Dec 8, 2023
@davidberard98
Revert "[dynamo] remove unused OptimizeCtx field - export (#113901)"
7e14410 
This reverts commit b62230a.

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Dec 8, 2023
@davidberard98
Update base for Update on "Revert "[dynamo] remove unused `OptimizeCt…
bb2f089 
…x` field - export (#113901)""

This reverts commit b62230a.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
davidberard98 added a commit that referenced this pull request Dec 8, 2023
@davidberard98
Update on "Revert "[dynamo] remove unused OptimizeCtx field - export (
c2f18ae 
#113901)""

This reverts commit b62230a.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Dec 10, 2023
@davidberard98 @pytorchmergebot
Revert "[dynamo] remove unused OptimizeCtx field - export (#113901)" (
b4ef59f 
#115401)

This reverts commit b62230a.

Differential Revision: [D52001024](https://our.internmc.facebook.com/intern/diff/D52001024)
Pull Request resolved: #115401
Approved by: https://github.com/malfet
ghstack dependencies: #115384
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
@davidberard98 @dmenig
Revert "[dynamo] remove unused OptimizeCtx field - export (pytorch#…
36a8023 
…113901)" (pytorch#115401)

This reverts commit b62230a.

Differential Revision: [D52001024](https://our.internmc.facebook.com/intern/diff/D52001024)
Pull Request resolved: pytorch#115401
Approved by: https://github.com/malfet
ghstack dependencies: pytorch#115384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: dynamo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jon-chuang @ezyang @pytorchmergebot @pytorchbot