[dynamo] Cache size calc for differing config#111300
Closed
jon-chuang wants to merge 29 commits intogh/jon-chuang/36/basefrom
Closed
[dynamo] Cache size calc for differing config#111300jon-chuang wants to merge 29 commits intogh/jon-chuang/36/basefrom
jon-chuang wants to merge 29 commits intogh/jon-chuang/36/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111300
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit d7496c5 with merge base 0ea126e ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 14, 2023
Collaborator
Author
|
@pytorchbot label "release notes: dynamo" |
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
ezyang
approved these changes
Nov 17, 2023
Contributor
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
Collaborator
Merge failedReason: New commits were pushed while merging. Please rerun the merge command. Details for Dev Infra teamRaised by workflow job |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Nov 17, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng ezyang Chillee [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot. |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
config_typing.pyitotorch.utils#113929OptimizeCtxfield - export #113901cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng @ezyang @Chillee