[Dynamo] cache_size policy#107496
Closed
anijain2305 wants to merge 21 commits intogh/anijain2305/111/basefrom
Closed
[Dynamo] cache_size policy#107496anijain2305 wants to merge 21 commits intogh/anijain2305/111/basefrom
anijain2305 wants to merge 21 commits intogh/anijain2305/111/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107496
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 4df4d5d with merge base 28dc1a0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
This was referenced Aug 21, 2023
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 15, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 15, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 25, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch of the existing global config with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111300 , based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
This was referenced Dec 20, 2025
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @aakhundov