[dynamo] config guard cache size limit#111145
Closed
jon-chuang wants to merge 29 commits intopytorch:mainfrom
Closed
[dynamo] config guard cache size limit#111145jon-chuang wants to merge 29 commits intopytorch:mainfrom
jon-chuang wants to merge 29 commits intopytorch:mainfrom
Conversation
…uang/global-config-guard
…uang/global-config-guard
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111145
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e925c25 with merge base 918054f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
4 tasks
Contributor
This PR needs a
|
Collaborator
Author
|
@pytorchbot label "release notes: dynamo" |
Contributor
|
since this isn't stacked I can't easily review it, removing from queue for now |
Collaborator
Author
|
@ezyang would it be possible to get branch creation permission on this repo? Running ghstack: |
Contributor
|
i sent you a gh invite |
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
jon-chuang
added a commit
that referenced
this pull request
Oct 14, 2023
--- Fixes: #110682 Replaces: #111074 The guards are installed based on config that is valid at the call to `torch.compile`, rather than at any subsequent call / triggered compilation. Subsequent compilations will restore the config if there is a config mismatch with the saved config. TODO: - [X] add tests Follow up PRs: - [x] add revised cache size computation (follow up PR: #111145, based on: #107496) - [ ] handle run-only mode? - [ ] config restoration itself is not thread-safe (tracked: #111150) cc voznesenskym ezyang Chillee [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to: #111074
CacheEntry are stored on f's
__code__object. We simply change the way of counting the cache size limitcc @voznesenskym @ezyang @Chillee