feat: report deprecated field usage in reconciled condition by Arpit529Srivastava · Pull Request #8236 · prometheus-operator/prometheus-operator

Arpit529Srivastava · 2026-01-03T20:46:35Z

Description

this PR reports deprecated field usage in the reconciled condition of Prometheus, Alertmanager and ThanosRuler CRDs.this change extends the existing logDeprecatedFields functions to also set the reconciled condition's reason to DeprecatedFieldsInUse and include the deprecation warnings in the message field. The condition status remains True (reconciliation is still successful), but users can now see deprecation warnings via kubectl get <resource> -o yaml.

Closes: #5681

If you're contributing for the first-time, check our contribution guidelines.

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

CHANGE (fix or feature that would cause existing functionality to not work as expected)
FEATURE (non-breaking change which adds functionality)
BUGFIX (non-breaking change which fixes an issue)
ENHANCEMENT (non-breaking change which improves existing functionality)
NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

changes are additive and don't modify existing Reconciled condition behavior when no deprecated fields are used
Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Report deprecated field usage in the Reconciled condition for Prometheus, Alertmanager, and ThanosRuler CRDs.

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava · 2026-01-03T22:01:45Z

cc: @simonpasquier PTAL
Thanks.

simonpasquier · 2026-01-05T09:44:15Z

pkg/alertmanager/operator.go

 }

-func logDeprecatedFields(logger *slog.Logger, a *monitoringv1.Alertmanager) {
+func logDeprecatedFields(logger *slog.Logger, a *monitoringv1.Alertmanager) string {


(suggestion) I would make it a method which can handle logging + recording the reason/message.

Suggested change

func logDeprecatedFields(logger *slog.Logger, a *monitoringv1.Alertmanager) string {

func (c *Opertor) recordDeprecatedFields(logger *slog.Logger, a *monitoringv1.Alertmanager) string {

makes sense, updating the implementation to use a method.

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava · 2026-01-05T10:30:17Z

cc: @simonpasquier, made the requested changes. PTAL
thanks.

pkg/prometheus/server/operator.go

simonpasquier · 2026-01-05T14:17:49Z

pkg/prometheus/server/operator.go

 	if p.Spec.BaseImage != "" {
-		logger.Warn(fmt.Sprintf(deprecationWarningf, "spec.baseImage", "spec.image"))
+		msg := fmt.Sprintf(deprecationWarningf, "spec.baseImage", "spec.image")
+		logger.Warn(msg)


(suggestion) we can accumulate all deprecations and log them altogether at the end.

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava · 2026-01-06T15:53:42Z

@simonpasquier PTAL, made the requested changes.
let me know if i miss anything.
thank you.

simonpasquier · 2026-01-09T12:27:19Z

pkg/alertmanager/operator.go

+
+	if len(deprecations) > 0 {
+		msg := strings.Join(deprecations, "; ")
+		logger.Warn(msg)


(nit) I'd prefer 1 log line per deprecated field. The same applies to the other places.

Suggested change

logger.Warn(msg)

for _, m := range deprecations {

logger.Warn(m)

}

pkg/prometheus/server/operator.go

…essage Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava · 2026-01-09T16:37:11Z

@simonpasquier PTAL.

Arpit529Srivastava · 2026-01-13T20:32:58Z

@simonpasquier if you can review this as well
thanks

simonpasquier

Thanks!

…r to v0.89.0 (#3775) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-operator/prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | minor | `v0.88.1` → `v0.89.0` | --- ### Release Notes <details> <summary>prometheus-operator/prometheus-operator (prometheus-operator/prometheus-operator)</summary> ### [`v0.89.0`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.89.0): 0.89.0 / 2026-02-05 [Compare Source](prometheus-operator/prometheus-operator@v0.88.1...v0.89.0) - \[ENHANCEMENT] Add `hostNetwork` field to the `Alertmanager` CRD. [#8281](prometheus-operator/prometheus-operator#8281) - \[ENHANCEMENT] Add the `crds` and `full-crds` commands to the operator's binary. [#8251](prometheus-operator/prometheus-operator#8251) - \[ENHANCEMENT] Report deprecated field usage in the `Reconciled` condition type. [#8236](prometheus-operator/prometheus-operator#8236) - \[ENHANCEMENT] Avoid unnecessary reconciliation upon creation of the `ThanosRuler` StatefulSet. [#8347](prometheus-operator/prometheus-operator#8347) - \[ENHANCEMENT] Add `bodySizeLimit` to the ScrapeConfig CRD. [#8348](prometheus-operator/prometheus-operator#8348) - \[ENHANCEMENT] Support `http_headers` field in the Alertmanager Secret. [#8357](prometheus-operator/prometheus-operator#8357) - \[ENHANCEMENT] Add the `-kubelet-http-metrics` flag to enable/disable the HTTP metrics port in the Kubelet endpoint (default=enabled). [#8350](prometheus-operator/prometheus-operator#8350) - \[ENHANCEMENT] Include `operator.prometheus.io/version` annotation in the full version of CRDs. [#8279](prometheus-operator/prometheus-operator#8279) - \[BUGFIX] Validate VictorOps global configuration in the `Alertmanager` CRD. [#8020](prometheus-operator/prometheus-operator#8020) - \[BUGFIX] Validate Jira global configuration in the `Alertmanager` CRD. [#8265](prometheus-operator/prometheus-operator#8265) - \[BUGFIX] Validate VictorOps receiver's URL in the `AlertmanagerConfig` CRD. [#8258](prometheus-operator/prometheus-operator#8258) - \[BUGFIX] Validate Webex receiver's URL in the `AlertmanagerConfig` CRD. [#8255](prometheus-operator/prometheus-operator#8255) - \[BUGFIX] Validate Jira receiver's URL configuration in the `AlertmanagerConfig` CRD. [#8230](prometheus-operator/prometheus-operator#8230) - \[BUGFIX] Validate OpsGenie receiver configuration in the `AlertmanagerConfig` CRD. [#8267](prometheus-operator/prometheus-operator#8267) - \[BUGFIX] Validate WeChat receiver configuration in the `AlertmanagerConfig` CRD. [#8271](prometheus-operator/prometheus-operator#8271) - \[BUGFIX] Validate SNS receiver configuration in the `AlertmanagerConfig` CRD. [#8217](prometheus-operator/prometheus-operator#8217) - \[BUGFIX] Validate Webex global configuration in the `Alertmanager` CRD. [#7979](prometheus-operator/prometheus-operator#7979) - \[BUGFIX] Validate Telegram global configuration in the `Alertmanager` CRD. [#8268](prometheus-operator/prometheus-operator#8268) - \[BUGFIX] Restore statefulset's labels if the creation fails with AlreadyExists. [#8343](prometheus-operator/prometheus-operator#8343) - \[BUGFIX] Fix potential panic due to informer cache races. [#8310](prometheus-operator/prometheus-operator#8310) - \[BUGFIX] Support probers defined with IPv6 addresses in the `Probe` CRD. [#8354](prometheus-operator/prometheus-operator#8354) - \[BUGFIX] Prevent group and repeat intervals with zero duration from breaking Alertmanager. [#8126](prometheus-operator/prometheus-operator#8126) - \[BUGFIX] Propagate all supported RocketChat attributes for `AlertmanagerConfig` CRD. [#8016](prometheus-operator/prometheus-operator#8016) - \[BUGFIX] Add URL validation for WeChat receiver. [#8256](prometheus-operator/prometheus-operator#8256) - \[BUGFIX] Add URL validation for SNS receiver. [#8259](prometheus-operator/prometheus-operator#8259) - \[BUGFIX] Fix GCE service discovery for the `ScrapeConfig` CRD. [#8284](prometheus-operator/prometheus-operator#8284) - \[BUGFIX] Avoid stale conditions in `Alertmanager`, `ThanosRuler`, `Prometheus` and `PrometheusAgent` resources. [#8304](prometheus-operator/prometheus-operator#8304) - \[BUGFIX] Fix race condition when updating rule ConfigMaps. [#8290](prometheus-operator/prometheus-operator#8290) - \[BUGFIX] Fix race condition when patching finalizers. [#8323](prometheus-operator/prometheus-operator#8323) - \[BUGFIX] Reconcile `ScrapeConfig` resources when namespace selection changes. [#8334](prometheus-operator/prometheus-operator#8334) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3775 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

…r to v0.89.0 ##### [\`v0.89.0\`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.89.0) - \[ENHANCEMENT] Add `hostNetwork` field to the `Alertmanager` CRD. [#8281](prometheus-operator/prometheus-operator#8281) - \[ENHANCEMENT] Add the `crds` and `full-crds` commands to the operator's binary. [#8251](prometheus-operator/prometheus-operator#8251) - \[ENHANCEMENT] Report deprecated field usage in the `Reconciled` condition type. [#8236](prometheus-operator/prometheus-operator#8236) - \[ENHANCEMENT] Avoid unnecessary reconciliation upon creation of the `ThanosRuler` StatefulSet. [#8347](prometheus-operator/prometheus-operator#8347) - \[ENHANCEMENT] Add `bodySizeLimit` to the ScrapeConfig CRD. [#8348](prometheus-operator/prometheus-operator#8348) - \[ENHANCEMENT] Support `http_headers` field in the Alertmanager Secret. [#8357](prometheus-operator/prometheus-operator#8357) - \[ENHANCEMENT] Add the `-kubelet-http-metrics` flag to enable/disable the HTTP metrics port in the Kubelet endpoint (default=enabled). [#8350](prometheus-operator/prometheus-operator#8350) - \[ENHANCEMENT] Include `operator.prometheus.io/version` annotation in the full version of CRDs. [#8279](prometheus-operator/prometheus-operator#8279) - \[BUGFIX] Validate VictorOps global configuration in the `Alertmanager` CRD. [#8020](prometheus-operator/prometheus-operator#8020) - \[BUGFIX] Validate Jira global configuration in the `Alertmanager` CRD. [#8265](prometheus-operator/prometheus-operator#8265) - \[BUGFIX] Validate VictorOps receiver's URL in the `AlertmanagerConfig` CRD. [#8258](prometheus-operator/prometheus-operator#8258) - \[BUGFIX] Validate Webex receiver's URL in the `AlertmanagerConfig` CRD. [#8255](prometheus-operator/prometheus-operator#8255) - \[BUGFIX] Validate Jira receiver's URL configuration in the `AlertmanagerConfig` CRD. [#8230](prometheus-operator/prometheus-operator#8230) - \[BUGFIX] Validate OpsGenie receiver configuration in the `AlertmanagerConfig` CRD. [#8267](prometheus-operator/prometheus-operator#8267) - \[BUGFIX] Validate WeChat receiver configuration in the `AlertmanagerConfig` CRD. [#8271](prometheus-operator/prometheus-operator#8271) - \[BUGFIX] Validate SNS receiver configuration in the `AlertmanagerConfig` CRD. [#8217](prometheus-operator/prometheus-operator#8217) - \[BUGFIX] Validate Webex global configuration in the `Alertmanager` CRD. [#7979](prometheus-operator/prometheus-operator#7979) - \[BUGFIX] Validate Telegram global configuration in the `Alertmanager` CRD. [#8268](prometheus-operator/prometheus-operator#8268) - \[BUGFIX] Restore statefulset's labels if the creation fails with AlreadyExists. [#8343](prometheus-operator/prometheus-operator#8343) - \[BUGFIX] Fix potential panic due to informer cache races. [#8310](prometheus-operator/prometheus-operator#8310) - \[BUGFIX] Support probers defined with IPv6 addresses in the `Probe` CRD. [#8354](prometheus-operator/prometheus-operator#8354) - \[BUGFIX] Prevent group and repeat intervals with zero duration from breaking Alertmanager. [#8126](prometheus-operator/prometheus-operator#8126) - \[BUGFIX] Propagate all supported RocketChat attributes for `AlertmanagerConfig` CRD. [#8016](prometheus-operator/prometheus-operator#8016) - \[BUGFIX] Add URL validation for WeChat receiver. [#8256](prometheus-operator/prometheus-operator#8256) - \[BUGFIX] Add URL validation for SNS receiver. [#8259](prometheus-operator/prometheus-operator#8259) - \[BUGFIX] Fix GCE service discovery for the `ScrapeConfig` CRD. [#8284](prometheus-operator/prometheus-operator#8284) - \[BUGFIX] Avoid stale conditions in `Alertmanager`, `ThanosRuler`, `Prometheus` and `PrometheusAgent` resources. [#8304](prometheus-operator/prometheus-operator#8304) - \[BUGFIX] Fix race condition when updating rule ConfigMaps. [#8290](prometheus-operator/prometheus-operator#8290) - \[BUGFIX] Fix race condition when patching finalizers. [#8323](prometheus-operator/prometheus-operator#8323) - \[BUGFIX] Reconcile `ScrapeConfig` resources when namespace selection changes. [#8334](prometheus-operator/prometheus-operator#8334) --- ##### [\`v0.88.1\`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.88.1) - \[BUGFIX] Validate `webhookURL` secret for `MSTeams` receiver in `AlertmanagerConfig` CRD. [#8294](prometheus-operator/prometheus-operator#8294) - \[BUGFIX] Revert maximum version check for `EC2/Lightsail` SD in `ScrapeConfig` CRD. [#8308](prometheus-operator/prometheus-operator#8308) - \[BUGFIX] Relax URL validation in `Slack` receiver in AlertmanagerConfig CRD to support Go templates. [#8299](prometheus-operator/prometheus-operator#8299) [#8331](prometheus-operator/prometheus-operator#8331) - \[BUGFIX] Relax URL validation in `PagerDuty` in AlertmanagerConfig CRD to support Go templates. [#8319](prometheus-operator/prometheus-operator#8319) - \[BUGFIX] Relax URL validation in `WebhookConfig` in AlertmanagerConfig CRD to support Go templates. [#8307](prometheus-operator/prometheus-operator#8307) [#8317](prometheus-operator/prometheus-operator#8317) - \[BUGFIX] Relax URL validation in `RocketChat` receiver in AlertmanagerConfig CRD to support Go templates. [#8318](prometheus-operator/prometheus-operator#8318) - \[BUGFIX] Relax URL validation in `Pushover` receiver in AlertmanagerConfig CRD to support Go templates. [#8307](prometheus-operator/prometheus-operator#8307) [#8316](prometheus-operator/prometheus-operator#8316)

feat: report deprecated field usage

bd4ae7c

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava requested a review from a team as a code owner January 3, 2026 20:46

pull-request-size bot added the size/M label Jan 3, 2026

simonpasquier reviewed Jan 5, 2026

View reviewed changes

refactor: rename deprecated fields logger method

1e95d74

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

simonpasquier reviewed Jan 5, 2026

View reviewed changes

pkg/prometheus/server/operator.go Show resolved Hide resolved

simonpasquier reviewed Jan 5, 2026

View reviewed changes

refactor: deprecation logging cleanup

41fa7a8

Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava requested a review from simonpasquier January 9, 2026 06:14

simonpasquier reviewed Jan 9, 2026

View reviewed changes

fix: log deprecations individually and update unmanagedConfigurationM…

34afa83

…essage Signed-off-by: arpit529srivastava <arpitsrivastava529@gmail.com>

Arpit529Srivastava requested a review from simonpasquier January 9, 2026 16:37

simonpasquier approved these changes Jan 14, 2026

View reviewed changes

simonpasquier merged commit 23d8375 into prometheus-operator:main Jan 14, 2026
22 checks passed

Arpit529Srivastava deleted the feat-issue-5681 branch January 14, 2026 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: report deprecated field usage in reconciled condition#8236

feat: report deprecated field usage in reconciled condition#8236
simonpasquier merged 4 commits intoprometheus-operator:mainfrom
Arpit529Srivastava:feat-issue-5681

Arpit529Srivastava commented Jan 3, 2026

Uh oh!

Arpit529Srivastava commented Jan 3, 2026

Uh oh!

simonpasquier Jan 5, 2026

Uh oh!

Arpit529Srivastava Jan 5, 2026

Uh oh!

Arpit529Srivastava commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

simonpasquier Jan 5, 2026

Uh oh!

Arpit529Srivastava commented Jan 6, 2026

Uh oh!

simonpasquier Jan 9, 2026

Uh oh!

Uh oh!

Arpit529Srivastava commented Jan 9, 2026

Uh oh!

Arpit529Srivastava commented Jan 13, 2026

Uh oh!

simonpasquier left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	func logDeprecatedFields(logger slog.Logger, a monitoringv1.Alertmanager) string {
	func (c Opertor) recordDeprecatedFields(logger slog.Logger, a *monitoringv1.Alertmanager) string {

-		logger.Warn(msg)
+		for _, m := range deprecations {
+		    logger.Warn(m)
+		}

Conversation

Arpit529Srivastava commented Jan 3, 2026

Description

Type of change

Verification

Changelog entry

Uh oh!

Arpit529Srivastava commented Jan 3, 2026

Uh oh!

simonpasquier Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Arpit529Srivastava Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Arpit529Srivastava commented Jan 5, 2026

Uh oh!

Uh oh!

Uh oh!

simonpasquier Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Arpit529Srivastava commented Jan 6, 2026

Uh oh!

simonpasquier Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Arpit529Srivastava commented Jan 9, 2026

Uh oh!

Arpit529Srivastava commented Jan 13, 2026

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants