feat: integrate all supported rocketchat attributes for alertmanagerconfig CR by tboerger · Pull Request #8016 · prometheus-operator/prometheus-operator

tboerger · 2025-10-10T12:13:41Z

Description

Currently the AlertmanagerConfig resource does not map all required fileds into the Alertmanager, with this change all currently supported attributes should be added.

I have no idea if it is OK to change this on both API versions, if there is something obviously wrong for you please tell me, it's my first contribution to this project.

Closes: #8009
Closes: #8008

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

CHANGE (fix or feature that would cause existing functionality to not work as expected)
FEATURE (non-breaking change which adds functionality)
BUGFIX (non-breaking change which fixes an issue)
ENHANCEMENT (non-breaking change which improves existing functionality)
NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Verification

Please check the Prometheus-Operator testing guidelines for recommendations about automated tests.
Added basic unit test.

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

Integrated supported attributes for RocketChat alerts within AlertmanagerConfig

tboerger · 2025-10-10T12:50:45Z

I can't see how the failing e2e tests are related to this PR

pkg/apis/monitoring/v1alpha1/alertmanager_config_types.go

tboerger · 2025-10-15T07:36:59Z

Anything else that is missing or should be changed?

tboerger · 2025-10-15T12:07:42Z

@simonpasquier as requested I have dropped the file attributes even that I still don't get why these attributes are fine for other providers than Rocket.Chat.

heliapb

Hi @tboerger could you just rebase and re-run make--always-make format generate, since the docs check is failing. Other than that lgtm. Thanks

tboerger · 2025-10-23T09:59:48Z

@heliapb just did that and pushed the fix.

tboerger · 2025-10-30T13:01:07Z

@simonpasquier anything else you want to have changed? Or are we ready to go for it? :)

pkg/alertmanager/operator.go

nutmos · 2025-12-21T08:57:00Z

Hi @simonpasquier , could you please also help review this as well?

simonpasquier

Sorry for reviewing this PR so late! I'd like to defer the API changes about optional vs. required fields for now: we have the problem elsewhere that the controller doesn't take into account the global configuration but I want to address it for all receivers (e.g. when selecting AlertmanagerConfig resources, the controller should know if there's a fallback value for a required field in the global config).

Having said that, we can already fix #8009 (+ the other optional fields like color, emoji, ...)

tboerger · 2025-12-22T19:31:24Z

I can revert the token/tokenID part, but it would be great if the removal of the requirement can be integrated soonish as well as I don't want to configure the token within every AlertmanagerConfig in every namespace :)

tboerger · 2025-12-22T19:58:47Z

@simonpasquier I have reverted the change related to required/optional now with the latest commit.

piratetm · 2026-02-02T10:30:46Z

Hi @simonpasquier Is there any news? :)

simonpasquier

Sorry for the lag but we had a few road bumps around URL validation with the latest v0.88 and I wanted to be sure that we had everything settled before going back to this PR.

pkg/alertmanager/validation/v1alpha1/validation.go

…onfig CR

tboerger · 2026-02-04T20:50:15Z

@simonpasquier I have applied the request for ValidateTemplateURL.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

tboerger · 2026-02-05T11:11:37Z

Great to see it finally merged, thanks!

…r to v0.89.0 (#3775) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [prometheus-operator/prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | minor | `v0.88.1` → `v0.89.0` | --- ### Release Notes <details> <summary>prometheus-operator/prometheus-operator (prometheus-operator/prometheus-operator)</summary> ### [`v0.89.0`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.89.0): 0.89.0 / 2026-02-05 [Compare Source](prometheus-operator/prometheus-operator@v0.88.1...v0.89.0) - \[ENHANCEMENT] Add `hostNetwork` field to the `Alertmanager` CRD. [#8281](prometheus-operator/prometheus-operator#8281) - \[ENHANCEMENT] Add the `crds` and `full-crds` commands to the operator's binary. [#8251](prometheus-operator/prometheus-operator#8251) - \[ENHANCEMENT] Report deprecated field usage in the `Reconciled` condition type. [#8236](prometheus-operator/prometheus-operator#8236) - \[ENHANCEMENT] Avoid unnecessary reconciliation upon creation of the `ThanosRuler` StatefulSet. [#8347](prometheus-operator/prometheus-operator#8347) - \[ENHANCEMENT] Add `bodySizeLimit` to the ScrapeConfig CRD. [#8348](prometheus-operator/prometheus-operator#8348) - \[ENHANCEMENT] Support `http_headers` field in the Alertmanager Secret. [#8357](prometheus-operator/prometheus-operator#8357) - \[ENHANCEMENT] Add the `-kubelet-http-metrics` flag to enable/disable the HTTP metrics port in the Kubelet endpoint (default=enabled). [#8350](prometheus-operator/prometheus-operator#8350) - \[ENHANCEMENT] Include `operator.prometheus.io/version` annotation in the full version of CRDs. [#8279](prometheus-operator/prometheus-operator#8279) - \[BUGFIX] Validate VictorOps global configuration in the `Alertmanager` CRD. [#8020](prometheus-operator/prometheus-operator#8020) - \[BUGFIX] Validate Jira global configuration in the `Alertmanager` CRD. [#8265](prometheus-operator/prometheus-operator#8265) - \[BUGFIX] Validate VictorOps receiver's URL in the `AlertmanagerConfig` CRD. [#8258](prometheus-operator/prometheus-operator#8258) - \[BUGFIX] Validate Webex receiver's URL in the `AlertmanagerConfig` CRD. [#8255](prometheus-operator/prometheus-operator#8255) - \[BUGFIX] Validate Jira receiver's URL configuration in the `AlertmanagerConfig` CRD. [#8230](prometheus-operator/prometheus-operator#8230) - \[BUGFIX] Validate OpsGenie receiver configuration in the `AlertmanagerConfig` CRD. [#8267](prometheus-operator/prometheus-operator#8267) - \[BUGFIX] Validate WeChat receiver configuration in the `AlertmanagerConfig` CRD. [#8271](prometheus-operator/prometheus-operator#8271) - \[BUGFIX] Validate SNS receiver configuration in the `AlertmanagerConfig` CRD. [#8217](prometheus-operator/prometheus-operator#8217) - \[BUGFIX] Validate Webex global configuration in the `Alertmanager` CRD. [#7979](prometheus-operator/prometheus-operator#7979) - \[BUGFIX] Validate Telegram global configuration in the `Alertmanager` CRD. [#8268](prometheus-operator/prometheus-operator#8268) - \[BUGFIX] Restore statefulset's labels if the creation fails with AlreadyExists. [#8343](prometheus-operator/prometheus-operator#8343) - \[BUGFIX] Fix potential panic due to informer cache races. [#8310](prometheus-operator/prometheus-operator#8310) - \[BUGFIX] Support probers defined with IPv6 addresses in the `Probe` CRD. [#8354](prometheus-operator/prometheus-operator#8354) - \[BUGFIX] Prevent group and repeat intervals with zero duration from breaking Alertmanager. [#8126](prometheus-operator/prometheus-operator#8126) - \[BUGFIX] Propagate all supported RocketChat attributes for `AlertmanagerConfig` CRD. [#8016](prometheus-operator/prometheus-operator#8016) - \[BUGFIX] Add URL validation for WeChat receiver. [#8256](prometheus-operator/prometheus-operator#8256) - \[BUGFIX] Add URL validation for SNS receiver. [#8259](prometheus-operator/prometheus-operator#8259) - \[BUGFIX] Fix GCE service discovery for the `ScrapeConfig` CRD. [#8284](prometheus-operator/prometheus-operator#8284) - \[BUGFIX] Avoid stale conditions in `Alertmanager`, `ThanosRuler`, `Prometheus` and `PrometheusAgent` resources. [#8304](prometheus-operator/prometheus-operator#8304) - \[BUGFIX] Fix race condition when updating rule ConfigMaps. [#8290](prometheus-operator/prometheus-operator#8290) - \[BUGFIX] Fix race condition when patching finalizers. [#8323](prometheus-operator/prometheus-operator#8323) - \[BUGFIX] Reconcile `ScrapeConfig` resources when namespace selection changes. [#8334](prometheus-operator/prometheus-operator#8334) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/3775 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

…onfig CR (prometheus-operator#8016) * feat: integrate all supported rocketchat attributes for alertmanagerconfig CR * fix: drop rocketchat file references as requested * fix: correctly format the generated code * feat: move rocketchat validations into validation package * chore: revert token/tokenID optional requirement * feat: use ValidateTemplateURL for Rocket.Chat links * Simplify code Signed-off-by: Simon Pasquier <spasquie@redhat.com> --------- Signed-off-by: Simon Pasquier <spasquie@redhat.com> Co-authored-by: Simon Pasquier <spasquie@redhat.com>

…r to v0.89.0 ##### [\`v0.89.0\`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.89.0) - \[ENHANCEMENT] Add `hostNetwork` field to the `Alertmanager` CRD. [#8281](prometheus-operator/prometheus-operator#8281) - \[ENHANCEMENT] Add the `crds` and `full-crds` commands to the operator's binary. [#8251](prometheus-operator/prometheus-operator#8251) - \[ENHANCEMENT] Report deprecated field usage in the `Reconciled` condition type. [#8236](prometheus-operator/prometheus-operator#8236) - \[ENHANCEMENT] Avoid unnecessary reconciliation upon creation of the `ThanosRuler` StatefulSet. [#8347](prometheus-operator/prometheus-operator#8347) - \[ENHANCEMENT] Add `bodySizeLimit` to the ScrapeConfig CRD. [#8348](prometheus-operator/prometheus-operator#8348) - \[ENHANCEMENT] Support `http_headers` field in the Alertmanager Secret. [#8357](prometheus-operator/prometheus-operator#8357) - \[ENHANCEMENT] Add the `-kubelet-http-metrics` flag to enable/disable the HTTP metrics port in the Kubelet endpoint (default=enabled). [#8350](prometheus-operator/prometheus-operator#8350) - \[ENHANCEMENT] Include `operator.prometheus.io/version` annotation in the full version of CRDs. [#8279](prometheus-operator/prometheus-operator#8279) - \[BUGFIX] Validate VictorOps global configuration in the `Alertmanager` CRD. [#8020](prometheus-operator/prometheus-operator#8020) - \[BUGFIX] Validate Jira global configuration in the `Alertmanager` CRD. [#8265](prometheus-operator/prometheus-operator#8265) - \[BUGFIX] Validate VictorOps receiver's URL in the `AlertmanagerConfig` CRD. [#8258](prometheus-operator/prometheus-operator#8258) - \[BUGFIX] Validate Webex receiver's URL in the `AlertmanagerConfig` CRD. [#8255](prometheus-operator/prometheus-operator#8255) - \[BUGFIX] Validate Jira receiver's URL configuration in the `AlertmanagerConfig` CRD. [#8230](prometheus-operator/prometheus-operator#8230) - \[BUGFIX] Validate OpsGenie receiver configuration in the `AlertmanagerConfig` CRD. [#8267](prometheus-operator/prometheus-operator#8267) - \[BUGFIX] Validate WeChat receiver configuration in the `AlertmanagerConfig` CRD. [#8271](prometheus-operator/prometheus-operator#8271) - \[BUGFIX] Validate SNS receiver configuration in the `AlertmanagerConfig` CRD. [#8217](prometheus-operator/prometheus-operator#8217) - \[BUGFIX] Validate Webex global configuration in the `Alertmanager` CRD. [#7979](prometheus-operator/prometheus-operator#7979) - \[BUGFIX] Validate Telegram global configuration in the `Alertmanager` CRD. [#8268](prometheus-operator/prometheus-operator#8268) - \[BUGFIX] Restore statefulset's labels if the creation fails with AlreadyExists. [#8343](prometheus-operator/prometheus-operator#8343) - \[BUGFIX] Fix potential panic due to informer cache races. [#8310](prometheus-operator/prometheus-operator#8310) - \[BUGFIX] Support probers defined with IPv6 addresses in the `Probe` CRD. [#8354](prometheus-operator/prometheus-operator#8354) - \[BUGFIX] Prevent group and repeat intervals with zero duration from breaking Alertmanager. [#8126](prometheus-operator/prometheus-operator#8126) - \[BUGFIX] Propagate all supported RocketChat attributes for `AlertmanagerConfig` CRD. [#8016](prometheus-operator/prometheus-operator#8016) - \[BUGFIX] Add URL validation for WeChat receiver. [#8256](prometheus-operator/prometheus-operator#8256) - \[BUGFIX] Add URL validation for SNS receiver. [#8259](prometheus-operator/prometheus-operator#8259) - \[BUGFIX] Fix GCE service discovery for the `ScrapeConfig` CRD. [#8284](prometheus-operator/prometheus-operator#8284) - \[BUGFIX] Avoid stale conditions in `Alertmanager`, `ThanosRuler`, `Prometheus` and `PrometheusAgent` resources. [#8304](prometheus-operator/prometheus-operator#8304) - \[BUGFIX] Fix race condition when updating rule ConfigMaps. [#8290](prometheus-operator/prometheus-operator#8290) - \[BUGFIX] Fix race condition when patching finalizers. [#8323](prometheus-operator/prometheus-operator#8323) - \[BUGFIX] Reconcile `ScrapeConfig` resources when namespace selection changes. [#8334](prometheus-operator/prometheus-operator#8334) --- ##### [\`v0.88.1\`](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.88.1) - \[BUGFIX] Validate `webhookURL` secret for `MSTeams` receiver in `AlertmanagerConfig` CRD. [#8294](prometheus-operator/prometheus-operator#8294) - \[BUGFIX] Revert maximum version check for `EC2/Lightsail` SD in `ScrapeConfig` CRD. [#8308](prometheus-operator/prometheus-operator#8308) - \[BUGFIX] Relax URL validation in `Slack` receiver in AlertmanagerConfig CRD to support Go templates. [#8299](prometheus-operator/prometheus-operator#8299) [#8331](prometheus-operator/prometheus-operator#8331) - \[BUGFIX] Relax URL validation in `PagerDuty` in AlertmanagerConfig CRD to support Go templates. [#8319](prometheus-operator/prometheus-operator#8319) - \[BUGFIX] Relax URL validation in `WebhookConfig` in AlertmanagerConfig CRD to support Go templates. [#8307](prometheus-operator/prometheus-operator#8307) [#8317](prometheus-operator/prometheus-operator#8317) - \[BUGFIX] Relax URL validation in `RocketChat` receiver in AlertmanagerConfig CRD to support Go templates. [#8318](prometheus-operator/prometheus-operator#8318) - \[BUGFIX] Relax URL validation in `Pushover` receiver in AlertmanagerConfig CRD to support Go templates. [#8307](prometheus-operator/prometheus-operator#8307) [#8316](prometheus-operator/prometheus-operator#8316)

tboerger requested a review from a team as a code owner October 10, 2025 12:13

pull-request-size bot added the size/L label Oct 10, 2025

This was referenced Oct 10, 2025

AlertmanagerConfig requires token and tokenID for RocktChat #8008

Closed

AlertmanagerConfig drops the channel for RocketChat receivers #8009

Closed

heliapb reviewed Oct 10, 2025

View reviewed changes

pkg/apis/monitoring/v1alpha1/alertmanager_config_types.go Outdated Show resolved Hide resolved

tboerger force-pushed the rocketchat-mapping branch 2 times, most recently from 94d937e to 5a54a7b Compare October 15, 2025 12:16

metalmatze previously approved these changes Oct 20, 2025

View reviewed changes

heliapb reviewed Oct 23, 2025

View reviewed changes

tboerger force-pushed the rocketchat-mapping branch from 5a54a7b to 177e1a8 Compare October 23, 2025 09:57

tboerger dismissed metalmatze’s stale review via 5ca7b09 October 23, 2025 10:52

tboerger mentioned this pull request Oct 30, 2025

[kube-prometheus-stack] Alerting into RocketChat does not work prometheus-community/helm-charts#6243

Open

heliapb approved these changes Oct 31, 2025

View reviewed changes

tboerger requested a review from simonpasquier November 7, 2025 07:59

nutmos mentioned this pull request Dec 20, 2025

Feat: add iconURL, imageURL, thumbURL and actions validations to RocketChat #8042

Closed

5 tasks

nutmos reviewed Dec 20, 2025

View reviewed changes

pkg/alertmanager/operator.go Outdated Show resolved Hide resolved

nutmos reviewed Dec 20, 2025

View reviewed changes

pkg/alertmanager/operator.go Outdated Show resolved Hide resolved

tboerger force-pushed the rocketchat-mapping branch from 5ca7b09 to 1633628 Compare December 20, 2025 10:31

pull-request-size bot added size/XXL and removed size/L labels Dec 20, 2025

tboerger force-pushed the rocketchat-mapping branch from 1633628 to 94d4947 Compare December 20, 2025 10:36

pull-request-size bot added size/L and removed size/XXL labels Dec 20, 2025

tboerger force-pushed the rocketchat-mapping branch from 94d4947 to 21e42d7 Compare December 21, 2025 09:57

simonpasquier reviewed Dec 22, 2025

View reviewed changes

tboerger force-pushed the rocketchat-mapping branch from 8c375b8 to d5b01e3 Compare December 22, 2025 19:57

simonpasquier reviewed Feb 4, 2026

View reviewed changes

tboerger added 6 commits February 4, 2026 21:44

feat: integrate all supported rocketchat attributes for alertmanagerc…

4da5c9e

…onfig CR

fix: drop rocketchat file references as requested

967c797

fix: correctly format the generated code

63abd1a

feat: move rocketchat validations into validation package

53cfd35

chore: revert token/tokenID optional requirement

2165605

feat: use ValidateTemplateURL for Rocket.Chat links

22f5e2e

tboerger force-pushed the rocketchat-mapping branch from d5b01e3 to 22f5e2e Compare February 4, 2026 20:49

Simplify code

0218438

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier enabled auto-merge (squash) February 5, 2026 10:26

slashpai approved these changes Feb 5, 2026

View reviewed changes

simonpasquier merged commit 5e8d9c5 into prometheus-operator:main Feb 5, 2026
22 checks passed

tboerger deleted the rocketchat-mapping branch February 5, 2026 11:11

Conversation

tboerger commented Oct 10, 2025

Description

Type of change

Verification

Changelog entry

Uh oh!

tboerger commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tboerger commented Oct 15, 2025

Uh oh!

tboerger commented Oct 15, 2025

Uh oh!

heliapb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tboerger commented Oct 23, 2025

Uh oh!

tboerger commented Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

nutmos commented Dec 21, 2025

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

tboerger commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tboerger commented Dec 22, 2025

Uh oh!

piratetm commented Feb 2, 2026

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tboerger commented Feb 4, 2026

Uh oh!

Uh oh!

tboerger commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tboerger commented Oct 10, 2025 •

edited

Loading

heliapb left a comment •

edited

Loading

tboerger commented Dec 22, 2025 •

edited

Loading