Skip to content

Add missing header #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrick96 merged 1 commit into from
Dec 12, 2020
Merged

Add missing header #2280

patrick96 merged 1 commit into from
Dec 12, 2020

Conversation

@vaygr
Copy link
Contributor

@vaygr vaygr commented Dec 7, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: compilation fix

Description

After upgrading from 3.4.3 to 3.5.0 I get this while building:

In file included from /usr/src/polybar-3.5.0/src/utils/process.cpp:1:
/usr/src/polybar-3.5.0/include/utils/process.hpp:8:26: error: unknown type name 'pid_t'
  bool in_parent_process(pid_t pid);
                         ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:9:26: error: unknown type name 'pid_t'
  bool in_forked_process(pid_t pid);
                         ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:13:3: error: unknown type name 'pid_t'
  pid_t fork_detached(std::function<void()> const& lambda);
  ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:18:3: error: unknown type name 'pid_t'
  pid_t wait_for_completion(pid_t process_id, int* status_addr = nullptr, int waitflags = 0);
  ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:18:29: error: unknown type name 'pid_t'
  pid_t wait_for_completion(pid_t process_id, int* status_addr = nullptr, int waitflags = 0);
                            ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:19:3: error: unknown type name 'pid_t'
  pid_t wait_for_completion(int* status_addr, int waitflags = 0);
  ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:20:3: error: unknown type name 'pid_t'
  pid_t wait_for_completion_nohang(pid_t process_id, int* status);
  ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:20:36: error: unknown type name 'pid_t'
  pid_t wait_for_completion_nohang(pid_t process_id, int* status);
                                   ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:21:3: error: unknown type name 'pid_t'
  pid_t wait_for_completion_nohang(int* status);
  ^
/usr/src/polybar-3.5.0/include/utils/process.hpp:22:3: error: unknown type name 'pid_t'
  pid_t wait_for_completion_nohang();
  ^
10 errors generated.

But not sure where it's coming from. The appropriate header doesn't get included in common.hpp? I guess the one in process.cpp becomes redundant.

Related Issues & Documents

N/A

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

patrick96
patrick96 approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patrick96 patrick96 merged commit f6231f3 into polybar:hotfix/3.5.1 Dec 12, 2020
@vaygr vaygr deleted the pid_t-header-fix branch December 12, 2020 00:09
patrick96 added a commit that referenced this pull request Dec 12, 2020
@patrick96
Release 3.5.1
9ba805d 
Changelog

**Features**

* config: Multiple inheritance (#2271), see #2269

**Fixes**

* (#2285), see #770, #2289
* Timer module: Polybar crash when interval is set to 0 (#2274), see #2273
* `custom/menu`: Wrong level numbers in error messages (#2264)
* `internal/xworkspaces`: Ignored certain workspace updates (#2275), see #2272
* Logger: Undefined behavior (#2284)
* build:
    * Build issues in older clang versions (#2270, #2279, #2280)
@patrick96 patrick96 mentioned this pull request Dec 12, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaygr @patrick96