fix(menu): Wrong printf token in error message #2264
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'level' is a string, not an integer
8ceec7b to
3736050
Compare
Codecov Report
@@ Coverage Diff @@
## hotfix/3.5.1 #2264 +/- ##
===============================================
+ Coverage 7.31% 7.34% +0.02%
===============================================
Files 155 155
Lines 10634 10596 -38
===============================================
Hits 778 778
+ Misses 9856 9818 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
added a commit
that referenced
this pull request
Dec 12, 2020
Changelog **Features** * config: Multiple inheritance (#2271), see #2269 **Fixes** * (#2285), see #770, #2289 * Timer module: Polybar crash when interval is set to 0 (#2274), see #2273 * `custom/menu`: Wrong level numbers in error messages (#2264) * `internal/xworkspaces`: Ignored certain workspace updates (#2275), see #2272 * Logger: Undefined behavior (#2284) * build: * Build issues in older clang versions (#2270, #2279, #2280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
'level' is a string, not an integer
This targets the hotfix branch for 3.5.1. Since this isn't really an critical bug, I think we can leave the hotfix branch for a bit and see if there are other bugs in 3.5.0 that need fixing.
Related Issues & Documents
Documentation (check all applicable)