Fix linking when built with clang++ 3.4 #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2270 +/- ##
=========================================
+ Coverage 7.31% 7.52% +0.21%
=========================================
Files 155 156 +1
Lines 10634 10681 +47
=========================================
+ Hits 778 804 +26
- Misses 9856 9877 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
patrick96
approved these changes
Dec 5, 2020
Member
patrick96
left a comment
There was a problem hiding this comment.
Great! I'm glad we could find a small fix for this issue.
Thanks for adding the patch :)
patrick96
added a commit
that referenced
this pull request
Dec 12, 2020
Changelog **Features** * config: Multiple inheritance (#2271), see #2269 **Fixes** * (#2285), see #770, #2289 * Timer module: Polybar crash when interval is set to 0 (#2274), see #2273 * `custom/menu`: Wrong level numbers in error messages (#2264) * `internal/xworkspaces`: Ignored certain workspace updates (#2275), see #2272 * Logger: Undefined behavior (#2284) * build: * Build issues in older clang versions (#2270, #2279, #2280)
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Dec 13, 2020
The change in polybar#2270 accidentally broke how we access module types. module<Impl>::TYPE always points to the module superclass and it thus accesses its empty TYPE field. This mainly broke legacy action handling. Ref polybar#2270
9 tasks
patrick96
added a commit
to patrick96/polybar
that referenced
this pull request
Dec 13, 2020
The change in polybar#2270 accidentally broke how we access module types. module<Impl>::TYPE always points to the module superclass and it thus accesses its empty TYPE field. This mainly broke legacy action handling. Ref polybar#2270
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This fixes building polybar with clang++ 3.4.2.
Related Issues & Documents
An exemplar linking error, which we couldn't debug was this:
repeated for every compiled module.
Documentation (check all applicable)