Skip to content

Fix build with clang++ 3.4 #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
patrick96 merged 1 commit into from
Dec 12, 2020
Merged

Fix build with clang++ 3.4 #2279

patrick96 merged 1 commit into from
Dec 12, 2020

Conversation

@vaygr
Copy link
Contributor

@vaygr vaygr commented Dec 7, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: compilation fix

Description

A follow-up to #2270. Likely a bug in clang.

Related Issues & Documents

The build error it fixes is:

/usr/src/polybar-3.5.0/src/adapters/pulseaudio.cpp:60:10: error: no matching function for call to 'pa_context_get_sink_info_by_name'
--
  | op = pa_context_get_sink_info_by_name(m_context, DEFAULT_SINK, sink_info_callback, this);
  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  | /usr/include/pulse/introspect.h:268:15: note: candidate function not viable: no known conversion from 'const std::initializer_list<const char *>' to 'const char *' for 2nd argument
  | pa_operation* pa_context_get_sink_info_by_name(pa_context *c, const char *name, pa_sink_info_cb_t cb, void *userdata);
  | ^
  | /usr/src/polybar-3.5.0/src/adapters/pulseaudio.cpp:134:13: error: no matching function for call to 'pa_context_get_sink_info_by_name'
  | o = pa_context_get_sink_info_by_name(m_context, DEFAULT_SINK, sink_info_callback, this);
  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  | /usr/include/pulse/introspect.h:268:15: note: candidate function not viable: no known conversion from 'const std::initializer_list<const char *>' to 'const char *' for 2nd argument
  | pa_operation* pa_context_get_sink_info_by_name(pa_context *c, const char *name, pa_sink_info_cb_t cb, void *userdata);
  | ^
  | 2 errors generated.

Built against PulseAudio 12.2.

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@patrick96 patrick96 merged commit d665634 into polybar:hotfix/3.5.1 Dec 12, 2020
@vaygr vaygr deleted the pulseaudio-build-fix branch December 12, 2020 00:09
patrick96 added a commit that referenced this pull request Dec 12, 2020
@patrick96
Release 3.5.1
9ba805d 
Changelog

**Features**

* config: Multiple inheritance (#2271), see #2269

**Fixes**

* (#2285), see #770, #2289
* Timer module: Polybar crash when interval is set to 0 (#2274), see #2273
* `custom/menu`: Wrong level numbers in error messages (#2264)
* `internal/xworkspaces`: Ignored certain workspace updates (#2275), see #2272
* Logger: Undefined behavior (#2284)
* build:
    * Build issues in older clang versions (#2270, #2279, #2280)
@patrick96 patrick96 mentioned this pull request Dec 12, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrick96 patrick96 patrick96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vaygr @patrick96