Skip to content

Sorry i have implemented to much here.#5

Merged
phproberto merged 1 commit intophproberto:usergroupsfrom
zero-24:patch-16
Aug 31, 2016
Merged

Sorry i have implemented to much here.#5
phproberto merged 1 commit intophproberto:usergroupsfrom
zero-24:patch-16

Conversation

@zero-24
Copy link
Copy Markdown

@zero-24 zero-24 commented Aug 31, 2016

https://travis-ci.org/joomla/joomla-cms/jobs/156466958

FILE: ...home/travis/build/joomla/joomla-cms/libraries/cms/helper/usergroups.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 69 | ERROR | Constructor and destructor comments must not have a @return tag
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

@phproberto phproberto merged commit 2d15209 into phproberto:usergroups Aug 31, 2016
@zero-24 zero-24 deleted the patch-16 branch August 31, 2016 10:23
phproberto pushed a commit that referenced this pull request Jan 24, 2017
- Improved readability of assertions by using more appropriate assertions
- Made some assertions more strict
phproberto pushed a commit that referenced this pull request Jun 21, 2017
… (joomla#12294)

* Cleanups, fixes and a bit of optimizations for site/components batch #5

- com_tags
- com_users
- com_wrapper

Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Some more fixes after conflict resolution

* - Changed some things according to reviewer's suggestions
- Some more changes in updated stuff
phproberto pushed a commit that referenced this pull request Oct 15, 2018
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message joomla#6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message joomla#7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message joomla#8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants