Skip to content

__DEPLOY_VERSION__ for the new code#4

Merged
phproberto merged 3 commits intophproberto:usergroupsfrom
zero-24:patch-18
Aug 31, 2016
Merged

__DEPLOY_VERSION__ for the new code#4
phproberto merged 3 commits intophproberto:usergroupsfrom
zero-24:patch-18

Conversation

@zero-24
Copy link
Copy Markdown

@zero-24 zero-24 commented Aug 31, 2016

Pull Request for Issue joomla#11853

Summary of Changes

__DEPLOY_VERSION__ tags for the new code.

Testing Instructions

Please review.

@zero-24
Copy link
Copy Markdown
Author

zero-24 commented Aug 31, 2016

Thanks

@zero-24 zero-24 deleted the patch-18 branch August 31, 2016 09:37
phproberto pushed a commit that referenced this pull request Oct 27, 2016
phproberto pushed a commit that referenced this pull request Oct 27, 2016
default needs to be enabled by default for B/C
phproberto pushed a commit that referenced this pull request Jan 24, 2017
- removal of some unused variables (and inserted todo's if unclear)
- removal of null assignments on class properties;
phproberto pushed a commit that referenced this pull request Jan 24, 2017
phproberto pushed a commit that referenced this pull request Jun 21, 2017
… (joomla#12293)

* Cleanups, fixes and a bit of optimizations for site/components batch #4

- com_mailto
- com_newsfeeds
- com_search

Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Missed to convert `and` and `or`

* Some more fixes after conflict resolution

* - Changed some things according to reviewer's suggestions
- Some more changes in updated stuff

* Reversed a change according to reviewer's correct comment.
phproberto pushed a commit that referenced this pull request Oct 15, 2018
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message joomla#6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message joomla#7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message joomla#8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants