Skip to content

Some very minor CS and doc blocks#3

Closed
zero-24 wants to merge 3 commits intophproberto:jlayoutfrom
zero-24:patch-2
Closed

Some very minor CS and doc blocks#3
zero-24 wants to merge 3 commits intophproberto:jlayoutfrom
zero-24:patch-2

Conversation

@zero-24
Copy link
Copy Markdown

@zero-24 zero-24 commented Nov 2, 2015

@phproberto this are just a very mirror PR to fix some CS and a few doc blocks ;)

@phproberto
Copy link
Copy Markdown
Owner

Merged in 361cf1a

Thanks!

@phproberto phproberto closed this Nov 2, 2015
@zero-24 zero-24 deleted the patch-2 branch November 2, 2015 11:06
@zero-24
Copy link
Copy Markdown
Author

zero-24 commented Nov 2, 2015

👍

phproberto pushed a commit that referenced this pull request Nov 11, 2015
phproberto pushed a commit that referenced this pull request Jan 24, 2017
… (joomla#12292)

* Cleanups, fixes and a bit of optimizations for site/components batch #3

- com_content

Note: This is a single commit bundling all types of changes, since PR joomla#12261 which had detailed commits, was rejected as a whole

* Ch-Ch-Ch-Changes!

Made some changes as pointed out by @andrepereiradasilva

* A bit more...

* Revert

* Removed empty function, as there is a fallback. Change made according to comment from @wilsonge

* Included @andrepereiradasilva's suggestions

* Inserting whitespace before php closing tag
phproberto pushed a commit that referenced this pull request Jan 24, 2017
* Replace unnecessary double quotes

* And one unnecessary semicolon... ;)

* CS Fix + removal of unnecessary space

* some more double quote replacements

* Changes, based on @shur's comments
phproberto pushed a commit that referenced this pull request Jan 24, 2017
* Some improvements in tests #3:
- call static methods correctly

* Fix T_PAAMAYIM_NEKUDOTAYIM (for all PHP 5.x)

* Remove forgotten call

* Changed a few things after conversation with @mbabker

* Fixes according to @andrepereiradasilva's comments
phproberto pushed a commit that referenced this pull request Oct 15, 2018
* This is a combination of 8 commits.
This is the 1st commit message:

> First WIP version of supporting nested subforms.

This is the commit message #2:

> Fix nested subforms not getting correct name attribute on input fields.

This is the commit message #3:

> Fix subform rows having invalid index, fix small typo.

This is the commit message #4:

> Replace the unique subform id via random bytes by just an increasing integer in the fields type rendering process.

This is the commit message #5:

> Implement feedback from PR at Joomla;
> - Use a <template> HTML element for the template of the subform rows,
>   not a url encoded string inside of a <script> element.
> - Fix code style errors reported by phpcs.
> - Make the fixing of the unique attributes (name, id, etc) of input elements
>   of nested subform rows more errorprone, using the same method as the main
>   subform row.
> - Manually add a minified version of the javascript file.

This is the commit message joomla#6:

> Fix failing javascript tests due to changed structure of subform repeatable template container.

This is the commit message joomla#7:

> Change subform repeatable javascript test to correctly check on
> 0-indexed rows, previously they have been 1-indexed.

This is the commit message joomla#8:

> Fix a problem where multi-level subforms on the same level doesnt trigger their template correctly.
> Additionally added a note why the fixScripts() method is broken and how it could get better.

* Commit code styling errors and add an aria label for the outermost 'add' button.

* Fix double group-add button on repeatable subform type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants