Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Change Application ID#110

Closed
scx wants to merge 8 commits intoparnoldx:masterfrom
scx:flatpak
Closed

Change Application ID#110
scx wants to merge 8 commits intoparnoldx:masterfrom
scx:flatpak

Conversation

@scx
Copy link
Copy Markdown
Contributor

@scx scx commented Feb 16, 2019

Change Application ID

Replace hyphen-minus with underscore.

Fixes #101

See also:


This Pull Request contains all previous ones:

  1. Use get_user_data_dir() instead of hardcoded path #106
  2. Enhance xdg files #107
  3. CMake: Add various fixes to CMakeLists.txt #108
  4. Port to Meson #109

Unfortunately, the ID change depends on all previous PRs.

You can accept just this PR if these patches suit you.
Or you can review each PR separately (except this one) and change the Application ID on your own. To do that, you can use the following command:

sed_exp='s!com\.github\.parnold-x\.nasc!com.github.parnold_x.nasc!g'; find * -xtype f \( -name '*.vala' -o -name 'com.github.parnold-x.nasc.*' -o -name 'CMakeLists.txt' -o -name 'meson.build' \) | xargs -I{} sed -i -re "${sed_exp}" '{}'; find * -xtype f -name 'com.github.parnold-x.nasc.*' | while read -r file; do d="$( dirname "${file}" )"; f="$( basename "${file}" )"; g="$( sed -re "${sed_exp}" <<< "${f}" )"; git mv "${d}/${f}" "${d}/${g}"; done; desktop-file-edit --set-key='X-Flatpak-RenamedFrom' --set-value='nasc.desktop;com.github.parnold-x.nasc.desktop;' data/*.desktop;

This PR is related to submitting my flatpak package to the Flathub repository.
#105
flathub/flathub#867

See also:
scx@f0142da

scx added 8 commits February 15, 2019 22:12
1. Update Categories
https://standards.freedesktop.org/menu-spec/latest/apa.html
https://standards.freedesktop.org/menu-spec/latest/apas02.html

2. Change GenericName
GenericName should be a generic name of the application,
for example "Web Browser".
The value should not be redundant with the values of Name and Comment.
https://developer.gnome.org/desktop-entry-spec/#recognized-keys

3. Add StartupWMClass and StartupNotify
http://www.freedesktop.org/Standards/startup-notification-spec
1. Update release notes
- Fix date for 0.5.0
- Add info about 0.5.1

2. Add screenshot captions

3. Add kudos

4. Add launchable tag

5. Fix indents
Fixes parnoldx#97 and parnoldx#103
parnoldx#97
parnoldx#103

Build app with static library.
The --thread option is now deprecated.
Should be ignored, but actually it leads to a build failure.
1. Rename src/config.vala.cmake to src/config.vala.in

2. Move com.github.parnold-x.nasc.gschema.xml to data subdirectory
Based on parnoldx#98
parnoldx#98

Fixes:
1. Fix dependencies for libqalculatenasc
parnoldx#98 (comment)

2. Remove header files from meson.build
parnoldx#98 (comment)

3. Get rid of get_option('prefix') from install_dir
parnoldx#98 (comment)

4. Make Meson optional
Do not remove CMake
@NathanBnm
Copy link
Copy Markdown
Contributor

You should NOT merge all PRs all in one, this is really confusing. @parnold-x since this is out of date now, I think you can close this.

@parnoldx parnoldx closed this May 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the app-id to a correct one

3 participants