This repository was archived by the owner on Sep 10, 2025. It is now read-only.
CMake: Add various fixes to CMakeLists.txt#108
Merged
parnoldx merged 2 commits intoparnoldx:masterfrom Feb 17, 2019
Merged
Conversation
Fixes parnoldx#97 and parnoldx#103 parnoldx#97 parnoldx#103 Build app with static library.
The --thread option is now deprecated. Should be ignored, but actually it leads to a build failure.
Closed
Contributor
Author
|
Before reviewing, please read this: |
This was referenced Feb 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMake: Fix linking
Build app with static library.
Fixes #97 and #103
See also:
https://build.opensuse.org/package/view_file/openSUSE:Factory/nasc/nasc-0.5.0-link.patch?expand=1
CMake: Remove --thread option for Vala Compiler
The
--threadoption is now deprecated.Should be ignored, but actually it leads to a build failure.
See also:
https://github.com/GNOME/vala/blob/f7c386eae4a1ab15eb4a21dce540e6298d93436c/compiler/valacompiler.vala#L131
This PR is related to submitting my flatpak package to the Flathub repository.
#105
flathub/flathub#867
See also:
scx#3