Skip to content

Add com.github.parnold_x.nasc (nasc-flatpak)#867

Closed
scx wants to merge 16 commits intoflathub:new-prfrom
scx:com.github.parnold_x.nasc
Closed

Add com.github.parnold_x.nasc (nasc-flatpak)#867
scx wants to merge 16 commits intoflathub:new-prfrom
scx:com.github.parnold_x.nasc

Conversation

@scx
Copy link
Copy Markdown

@scx scx commented Feb 16, 2019

NaSC is an app where you do maths like a normal person. It lets you type whatever you want and smartly figures out what is math and spits out an answer on the right pane. Then you can plug those answers in to future equations and if that answer changes, so does the equations it's used in.
https://github.com/scx/flathub/tree/com.github.parnold_x.nasc
https://github.com/scx/nasc-flatpak

See also:
http://parnold-x.github.io/nasc
https://github.com/parnold-x/nasc
https://github.com/scx/nasc/tree/flatpak

@scx scx mentioned this pull request Feb 16, 2019
@scx
Copy link
Copy Markdown
Author

scx commented Feb 16, 2019

Upstream participation request:
parnoldx/nasc#105

@scx
Copy link
Copy Markdown
Author

scx commented Feb 16, 2019

Previous application submission:
#128

Changes compared to the previous application submission:

  • Update NaSC to the latest version
  • Update GNOME runtime to 3.30
  • Use io.elementary.BaseApp
  • Use get_user_data_dir() instead of hardcoded path
  • Enhance desktop file
  • Enhance AppData file
  • Add various patches to the build scripts
  • Port to Meson
  • Change Application ID (another attempt)

@scx
Copy link
Copy Markdown
Author

scx commented Feb 16, 2019

@phw @AsciiWolf
Are you interested in co-maintaining this package?

@AsciiWolf
Copy link
Copy Markdown
Contributor

@scx Thanks for the offer, but I am probably not interested, sorry. I already maintain many Flathub apps.

@nedrichards
Copy link
Copy Markdown
Member

bot, build com.github.parnold_x.nasc
testbot, build com.github.parnold_x.nasc

@flathubbot
Copy link
Copy Markdown

Queued test build for com.github.parnold_x.nasc.

@flathubbot
Copy link
Copy Markdown

Started test build 124

@flathubbot
Copy link
Copy Markdown

Build 124 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/63/com.github.parnold_x.nasc.flatpakref

@scx
Copy link
Copy Markdown
Author

scx commented Feb 16, 2019

Fails on arm (cln):
https://flathub.org/builds/#/builders/2/builds/8228

@nedrichards
Copy link
Copy Markdown
Member

bot, build com.github.parnold_x.nasc

@flathubbot
Copy link
Copy Markdown

Queued test build for com.github.parnold_x.nasc.

@flathubbot
Copy link
Copy Markdown

Started test build 10648

@flathubbot
Copy link
Copy Markdown

Build 10648 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/10142/com.github.parnold_x.nasc.flatpakref

@scx
Copy link
Copy Markdown
Author

scx commented Oct 29, 2019

@scx
Copy link
Copy Markdown
Author

scx commented Nov 22, 2019

bot, build com.github.parnold_x.nasc

@flathubbot
Copy link
Copy Markdown

Queued test build for com.github.parnold_x.nasc.

@flathubbot
Copy link
Copy Markdown

Started test build 11727

@flathubbot
Copy link
Copy Markdown

Build 11727 failed

@scx
Copy link
Copy Markdown
Author

scx commented Nov 22, 2019

bot, build com.github.parnold_x.nasc

@flathubbot
Copy link
Copy Markdown

Queued test build for com.github.parnold_x.nasc.

@flathubbot
Copy link
Copy Markdown

Started test build 11733

@flathubbot
Copy link
Copy Markdown

Build 11733 was cancelled

@flathubbot
Copy link
Copy Markdown

Started test build 11734

@flathubbot
Copy link
Copy Markdown

Build 11734 failed

@flathubbot
Copy link
Copy Markdown

Started test build 11738

@flathubbot
Copy link
Copy Markdown

Build 11738 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11194/com.github.parnold_x.nasc.flatpakref

@scx
Copy link
Copy Markdown
Author

scx commented Nov 22, 2019

@scx
Copy link
Copy Markdown
Author

scx commented Nov 23, 2019

bot, build com.github.parnold_x.nasc

@flathubbot
Copy link
Copy Markdown

Queued test build for com.github.parnold_x.nasc.

@flathubbot
Copy link
Copy Markdown

Started test build 11758

@flathubbot
Copy link
Copy Markdown

Build 11758 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11214/com.github.parnold_x.nasc.flatpakref

@scx
Copy link
Copy Markdown
Author

scx commented Nov 23, 2019

Copy link
Copy Markdown
Member

@barthalion barthalion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common issues across your pull requests:

  • [] Modules are unnecesserarily split from the main manifest to external files.
  • [] Pointless installation of README/LICENSE/ChangeLog files.
  • [] Excessive patching, often without any connection to actual flatpak.
  • [] No upstream participation (or app is no longer developed).
  • [] post-install and cleanup are consistently below sources array, making it harder to read your manifests.
  • [] Too wide or unnecessary permissions (--filesystem=home with --persist=, dconf access).
  • [] Separate shell scripts for copying files.

There are also application-specific issues but makes no sense to list them if the list above remains unfixed.

@flathubbot
Copy link
Copy Markdown

This PR hasn't received any updates in a year and will be automatically closed in 14 days. Feel free to re-open it if you plan to continue working on that pull request or think it deserves attention from Flathub admins

@flathubbot flathubbot added the Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify label Jan 26, 2021
@flathubbot flathubbot closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale Stale PR, no activity for over a year. Used by automated workflows. Do not modify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants