Conversation
App where you do maths like a normal person. GPLv3, see upstream https://github.com/parnold-x/nasc Needs patching of App ID, see discussion on flatpak/flatpak-builder#37
|
If the patched app ID is going to change from I'll see if I can get the Desktop Entry Specification changed to recommend normalizing dashes to underscores when forming app IDs - that works better with |
|
Yes, your explanation makes a lot of sense here. I will update the patch. As I see it the app ID needs to be changed anyway, so once the patches are in that would be ok for Flatpak, right? Upstream NaSC changing the app ID depends on Elementary following your recommendation (what they hopefully will do) and whether it is feasible to change the app ID for an already published app. |
| "--filesystem=xdg-documents", | ||
| "--filesystem=xdg-public-share", | ||
| "--filesystem=xdg-run/dconf", | ||
| "--filesystem=~/.local/share/nasc/", |
There was a problem hiding this comment.
$XDG_DATA_HOME is set to another private location for you automatically so you shouldn't need to pass this through.
There was a problem hiding this comment.
Oh it does hardcode this path: https://github.com/parnold-x/nasc/blob/89c3d753fd0a82a82e2cddac7a3227bfcb979966/src/NascSettings.vala#L27
That should be patched out to respect the correct xdg directory: https://valadoc.org/glib-2.0/GLib.Environment.get_user_data_dir.html
| "V": "1" | ||
| } | ||
| }, | ||
| "cleanup": [ |
There was a problem hiding this comment.
I didn't test it but you probably have extra gir files and such that aren't cleaned up, always good to go over every dir in the build directory.
Required to refresh qalculate currency data.
|
I fixed the app ID to use |
|
Test build at: https://flathub.org/builds/#/builders/1/builds/704 |
|
Just for a follow up: I still want to deal with the issues reported by @TingPing , but this has to wait 2-3 weeks as I am currently not able to get some time for this. |
|
bot, build com.github.parnold_x.nasc |
|
What is the status of this? Has it been abandoned? If so I would be willing to take it up. |
|
@rushsteve1 Not abondoned, but due to missing time (also for the forseeable future) unfortunately on ice. So feel free to continue where I left: Currently open is the issue reported by @TingPing above (hardcoded path to |
|
Any new updates on this? A newer version of NaSC is out which may or may not fix things. |
|
Any news? |
|
I'm closing it due to inactivity – but please re-open it or resubmit as new pull request if you would like to see it merged in the future. |
Fixes parnoldx#101 Replace hyphen-minus with underscore. See also: - elementary/houston#566 - flatpak/flatpak-builder#37 - parnoldx#67 - flathub/flathub#128
|
New attempt to create a flatpak package: See also: |
Fix window class name for 1.7.2
Using GitHub link to source download this time as it hasn't been uploaded to TuxFamily yet
Update gs and poppler-data
App where you do maths like a normal person. GPLv3, see upstream https://github.com/parnold-x/nasc
Needs patching of App ID, see discussion on flatpak/flatpak-builder#37
See also parnoldx/nasc#67