Conversation
|
Also, I have no idea why |
| 'libqalculatenasc', | ||
|
|
||
| 'QalculateNasc.cc', | ||
| 'QalculateNasc.h', |
There was a problem hiding this comment.
The header should be autodetected by meson.
There was a problem hiding this comment.
Does it hurt if it's added explicitly?
| @@ -0,0 +1,32 @@ | |||
| install_data( | |||
| meson.project_name() + '.appdata.xml', | |||
| install_dir: join_paths(get_option('prefix'), get_option('datadir'), 'metainfo') | |||
There was a problem hiding this comment.
No need for prefix here. It's added automatically on install_dir.
|
The last few rounds of review have just been nit-picking. I have no patience to care about this anymore. I hope my work can be useful for whoever wants to finish this. |
Based on parnoldx#98 parnoldx#98 Fixes: 1. Fix dependencies for libqalculatenasc parnoldx#98 (comment) 2. Remove header files from meson.build parnoldx#98 (comment) 3. Get rid of get_option('prefix') from install_dir parnoldx#98 (comment) 4. Make Meson optional Do not remove CMake
Based on parnoldx#98 parnoldx#98 Fixes: 1. Fix dependencies for libqalculatenasc parnoldx#98 (comment) 2. Remove header files from meson.build parnoldx#98 (comment) 3. Get rid of get_option('prefix') from install_dir parnoldx#98 (comment) 4. Make Meson optional Do not remove CMake
| 'QalculateNasc.h', | ||
|
|
||
| dependencies: [ | ||
| meson.get_compiler('cpp').find_library('libqalculate'), |
There was a problem hiding this comment.
You forgot about cln.
Replace this:
meson.get_compiler('cpp').find_library('libqalculate'),
with this:
dependency('cln'),
dependency('libqalculate'),
This should fix builds on Fedora < 28 and EL < 8, as well as on Freedesktop 18.08 and GNOME 3.30.
#98 (comment)
/usr/bin/ld: liblibqalculatenasc.a(libqalculatenasc_QalculateNasc.cc.o): undefined reference to symbol '_ZN3cln24cl_GV_number_init_helperD1Ev'
//usr/lib/libcln.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
libqalculatenasc/meson.build:1:0: ERROR: C++ library 'libqalculate' not found
There was a problem hiding this comment.
Interesting ... that's the first time I read about the cln library. But since it fixes the problem ... 🤷♂️
|
See also: RPM package |
I ported the current CMake based build system to meson, preserving the behavior as far as possible. I've used this for building the latest fedora packages, and it seems to work as expected.
Suggestions for improvements are welcome 😄