refactor(ast): remove AstBuilder::alloc calls#23708
Merged
graphite-app[bot] merged 1 commit intoJun 22, 2026
Merged
Conversation
Member
Author
This was referenced Jun 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors AstBuilder convenience helpers to use the shorter arena-allocation helpers (alloc_*) directly, instead of building an owned node first and then calling AstBuilder::alloc(...).
Changes:
- Replace
self.alloc(self.unary_expression(...))withself.alloc_unary_expression(...)invoid_0. - Replace
self.alloc(self.export_named_declaration(...))withself.alloc_export_named_declaration(...)inplain_export_named_declaration*helpers.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Member
Author
Merge activity
|
Pure refactor. Use shorter `alloc_*` methods of `AstBuilder` instead of using methods which build an owned type, and then calling `ast.alloc(...)` separately.
c8df7fb to
cf5e47e
Compare
This was referenced Jun 22, 2026
camc314
pushed a commit
that referenced
this pull request
Jul 3, 2026
Pure refactor. Use shorter `alloc_*` methods of `AstBuilder` instead of using methods which build an owned type, and then calling `ast.alloc(...)` separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor. Use shorter
alloc_*methods ofAstBuilderinstead of using methods which build an owned type, and then callingast.alloc(...)separately.