Skip to content

fix(linter): avoid enabling jest with vitest plugin#22499

Merged
graphite-app[bot] merged 1 commit into
mainfrom
c/fix-22498
May 17, 2026
Merged

fix(linter): avoid enabling jest with vitest plugin#22499
graphite-app[bot] merged 1 commit into
mainfrom
c/fix-22498

Conversation

@camc314

@camc314 camc314 commented May 17, 2026

Copy link
Copy Markdown
Contributor

now that jest/vitest rules are split, we don't need to enable jest plugin when vitest plugin is enabled via cli

fixes #22498

@github-actions github-actions Bot added A-linter Area - Linter A-cli Area - CLI labels May 17, 2026
@camc314 camc314 self-assigned this May 17, 2026
@camc314 camc314 marked this pull request as ready for review May 17, 2026 15:17
Copilot AI review requested due to automatic review settings May 17, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy behavior of auto-enabling the Jest plugin when the Vitest plugin is enabled. Since Jest and Vitest rules have been split into separate plugins, this implicit coupling is no longer necessary and was causing unwanted Jest rules to appear in printed configs (fixes #22498).

Changes:

  • Drop the implicit LintPlugins::JEST enablement triggered by vitest_plugin in EnablePlugins::apply_overrides.
  • Update the corresponding unit test expectation to no longer include LintPlugins::JEST.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 17, 2026

camc314 commented May 17, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

graphite-app Bot pushed a commit that referenced this pull request May 17, 2026
now that jest/vitest rules are split, we don't need to enable jest plugin when vitest plugin is enabled via cli

fixes #22498
now that jest/vitest rules are split, we don't need to enable jest plugin when vitest plugin is enabled via cli

fixes #22498
@graphite-app graphite-app Bot merged commit 5747ff1 into main May 17, 2026
26 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label May 17, 2026
@graphite-app graphite-app Bot deleted the c/fix-22498 branch May 17, 2026 15:27
camc314 pushed a commit that referenced this pull request May 18, 2026
# Oxlint
### 🚀 Features

- 1ae291e linter/no-underscore-dangle: Add `allowInUsingDeclarations`
option (#22483) (吴杨帆)
- 0440b0f linter/eslint: Implement `id-match` rule (#22379) (Vladislav
Sayapin)
- 65bf119 linter: Implement react no-object-type-as-default-prop
(#22481) (uhyo)
- 2a6ddce linter/eslint: Implement `no-implied-eval` rule (#22391)
(Vladislav Sayapin)
- d3a3c1d linter: Auto detect agents from CLI and transition to the
agent output format (#22068) (Jovi De Croock)
- 625758a linter/vitest: Implement padding-around-after-all-blocks rule
(#21788) (kapobajza)
- 37680b0 linter: Implement react no-unstable-nested-components (#22248)
(Jovi De Croock)
- d8d9c74 linter: Implement import/newline-after-import rule (#19142)
(Ryuya Yanagi)

### 🐛 Bug Fixes

- 3f59e03 linter: Only call rayon/miette/tracing inits once (#21899)
(Matiss Janis Aboltins)
- 602dfd6 linter/promise/no-return-wrap: Detect Promise calls in all
branches (#22474) (zennnnnnn11)
- e182aee linter: Allow dialogs and popovers for no_autofocus (#22289)
(mehm8128)
- 7ffb710 linter/jest/vitest: Jest/no-standalone-expect ignores
additionalTestBlockFunctions option for jest/vitest hooks (#22477)
(kapobajza)
- c6f2d3f linter: Add more expression support for iframe-has-title
(#22460) (mehm8128)
- 5747ff1 linter: Avoid enabling jest with vitest plugin (#22499)
(camc314)
- 863984f linter/no-find-dom-node: Run on all files (#22479) (bab)

### ⚡ Performance

- 2afef79 linter: Optimize `no-loop-func` (#22491) (camchenry)
- 4c9ca72 oxlint: Align walker thread count with rayon pool (#22494)
(Boshen)

### 📚 Documentation

- f7967c7 linter/id-match: Clarify `onlyDeclarations` config docs
(#22523) (camc314)
- 1e0c97f linter: Fix closing code block in documentation for
`padding-around-after-all-blocks` rule. (#22513) (connorshea)
- a9049fd linter: Exclude directly provide autoFocus to dialog pattern
(#22510) (mehm8128)
# Oxfmt
### 🐛 Bug Fixes

- 8ee946f formatter/sort_imports: Use label to classify lines (#22512)
(leaysgur)
- 8c1da44 formatter: Normalize destructuring keys in DCR (#22478)
(camc314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: Using --vitest-plugin CLI flag includes Jest rules

2 participants