Skip to content

fix(linter/no-find-dom-node): run on all files#22479

Merged
camc314 merged 4 commits into
oxc-project:mainfrom
babu-ch:fix/no-find-dom-node-ts
May 17, 2026
Merged

fix(linter/no-find-dom-node): run on all files#22479
camc314 merged 4 commits into
oxc-project:mainfrom
babu-ch:fix/no-find-dom-node-ts

Conversation

@babu-ch

@babu-ch babu-ch commented May 16, 2026

Copy link
Copy Markdown
Contributor

closes #22468

Comment thread crates/oxc_linter/src/rules/react/no_find_dom_node.rs Outdated
@codspeed-hq

codspeed-hq Bot commented May 16, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing babu-ch:fix/no-find-dom-node-ts (2eb6c97) with main (d6e6f4b)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@babu-ch babu-ch force-pushed the fix/no-find-dom-node-ts branch from 1883794 to c8c5aa6 Compare May 16, 2026 12:05
@babu-ch babu-ch marked this pull request as ready for review May 16, 2026 12:30
@camc314 camc314 changed the title fix(linter/no-find-dom-node): run on TypeScript files fix(linter/no-find-dom-node): run on all files May 17, 2026
@camc314 camc314 self-assigned this May 17, 2026
@camc314 camc314 added the A-linter Area - Linter label May 17, 2026
@camc314 camc314 merged commit 863984f into oxc-project:main May 17, 2026
27 checks passed
@babu-ch babu-ch deleted the fix/no-find-dom-node-ts branch May 18, 2026 06:48
camc314 pushed a commit that referenced this pull request May 18, 2026
# Oxlint
### 🚀 Features

- 1ae291e linter/no-underscore-dangle: Add `allowInUsingDeclarations`
option (#22483) (吴杨帆)
- 0440b0f linter/eslint: Implement `id-match` rule (#22379) (Vladislav
Sayapin)
- 65bf119 linter: Implement react no-object-type-as-default-prop
(#22481) (uhyo)
- 2a6ddce linter/eslint: Implement `no-implied-eval` rule (#22391)
(Vladislav Sayapin)
- d3a3c1d linter: Auto detect agents from CLI and transition to the
agent output format (#22068) (Jovi De Croock)
- 625758a linter/vitest: Implement padding-around-after-all-blocks rule
(#21788) (kapobajza)
- 37680b0 linter: Implement react no-unstable-nested-components (#22248)
(Jovi De Croock)
- d8d9c74 linter: Implement import/newline-after-import rule (#19142)
(Ryuya Yanagi)

### 🐛 Bug Fixes

- 3f59e03 linter: Only call rayon/miette/tracing inits once (#21899)
(Matiss Janis Aboltins)
- 602dfd6 linter/promise/no-return-wrap: Detect Promise calls in all
branches (#22474) (zennnnnnn11)
- e182aee linter: Allow dialogs and popovers for no_autofocus (#22289)
(mehm8128)
- 7ffb710 linter/jest/vitest: Jest/no-standalone-expect ignores
additionalTestBlockFunctions option for jest/vitest hooks (#22477)
(kapobajza)
- c6f2d3f linter: Add more expression support for iframe-has-title
(#22460) (mehm8128)
- 5747ff1 linter: Avoid enabling jest with vitest plugin (#22499)
(camc314)
- 863984f linter/no-find-dom-node: Run on all files (#22479) (bab)

### ⚡ Performance

- 2afef79 linter: Optimize `no-loop-func` (#22491) (camchenry)
- 4c9ca72 oxlint: Align walker thread count with rayon pool (#22494)
(Boshen)

### 📚 Documentation

- f7967c7 linter/id-match: Clarify `onlyDeclarations` config docs
(#22523) (camc314)
- 1e0c97f linter: Fix closing code block in documentation for
`padding-around-after-all-blocks` rule. (#22513) (connorshea)
- a9049fd linter: Exclude directly provide autoFocus to dialog pattern
(#22510) (mehm8128)
# Oxfmt
### 🐛 Bug Fixes

- 8ee946f formatter/sort_imports: Use label to classify lines (#22512)
(leaysgur)
- 8c1da44 formatter: Normalize destructuring keys in DCR (#22478)
(camc314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: react/no-find-dom-node not triggering on TS files, only TSX

3 participants