Skip to content

fix(linter): allow dialogs and popovers for no_autofocus#22289

Merged
camchenry merged 2 commits into
oxc-project:mainfrom
mehm8128:fix/allow-dialogs-and-popovers-for-no_autofocus
May 17, 2026
Merged

fix(linter): allow dialogs and popovers for no_autofocus#22289
camchenry merged 2 commits into
oxc-project:mainfrom
mehm8128:fix/allow-dialogs-and-popovers-for-no_autofocus

Conversation

@mehm8128

@mehm8128 mehm8128 commented May 10, 2026

Copy link
Copy Markdown
Contributor

close #22287

Since we haven't discussed whether this change is appropriate, please let me know if there are any concerns.

@mehm8128 mehm8128 requested a review from camc314 as a code owner May 10, 2026 14:30
@codspeed-hq

codspeed-hq Bot commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1

Comparing mehm8128:fix/allow-dialogs-and-popovers-for-no_autofocus (5f8d566) with main (3c53a95)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (7f66035) during the generation of this report, so 3c53a95 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sysix
Sysix reviewed May 10, 2026
View reviewed changes
Comment thread crates/oxc_linter/src/rules/jsx_a11y/no_autofocus.rs Outdated
@camc314 camc314 added the A-linter Area - Linter label May 11, 2026
@camchenry camchenry self-assigned this May 12, 2026
@mehm8128 mehm8128 requested a review from Sysix May 13, 2026 15:09
camchenry
camchenry approved these changes May 17, 2026
View reviewed changes

@camchenry camchenry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good step, at least based on what I'm understanding from the original PR that updated the spec: whatwg/html#8199.

<dialog autofocus> is valid and has defined behavior, but it seems like it would be better for developers to either not specify it (and fall back to the defined behavior for finding focusable elements), or define a specific element inside with autofocus. That is what this PR represents, so I'm in favor.

@camchenry camchenry merged commit e182aee into oxc-project:main May 17, 2026
28 checks passed
@mehm8128

mehm8128 commented May 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Thank you!
I forgot to exclude <dialog autofocus /> from correct example docs, I'll create an another PR to remove it.

@mehm8128 mehm8128 mentioned this pull request May 18, 2026
Merged
camchenry pushed a commit that referenced this pull request May 18, 2026
@mehm8128
docs(linter): exclude directly provide autoFocus to dialog pattern (#…
a9049fd 
…22510)

I forgot to exclude `<dialog autoFocus />` from correct pattern docs, so
I removed them.
ref: #22289
@oxc-guard oxc-guard Bot mentioned this pull request May 18, 2026
Merged
camc314 pushed a commit that referenced this pull request May 18, 2026
@oxc-guard
release(apps): oxlint v1.66.0 && oxfmt v0.51.0 (#22528)
5570206 
# Oxlint
### 🚀 Features

- 1ae291e linter/no-underscore-dangle: Add `allowInUsingDeclarations`
option (#22483) (吴杨帆)
- 0440b0f linter/eslint: Implement `id-match` rule (#22379) (Vladislav
Sayapin)
- 65bf119 linter: Implement react no-object-type-as-default-prop
(#22481) (uhyo)
- 2a6ddce linter/eslint: Implement `no-implied-eval` rule (#22391)
(Vladislav Sayapin)
- d3a3c1d linter: Auto detect agents from CLI and transition to the
agent output format (#22068) (Jovi De Croock)
- 625758a linter/vitest: Implement padding-around-after-all-blocks rule
(#21788) (kapobajza)
- 37680b0 linter: Implement react no-unstable-nested-components (#22248)
(Jovi De Croock)
- d8d9c74 linter: Implement import/newline-after-import rule (#19142)
(Ryuya Yanagi)

### 🐛 Bug Fixes

- 3f59e03 linter: Only call rayon/miette/tracing inits once (#21899)
(Matiss Janis Aboltins)
- 602dfd6 linter/promise/no-return-wrap: Detect Promise calls in all
branches (#22474) (zennnnnnn11)
- e182aee linter: Allow dialogs and popovers for no_autofocus (#22289)
(mehm8128)
- 7ffb710 linter/jest/vitest: Jest/no-standalone-expect ignores
additionalTestBlockFunctions option for jest/vitest hooks (#22477)
(kapobajza)
- c6f2d3f linter: Add more expression support for iframe-has-title
(#22460) (mehm8128)
- 5747ff1 linter: Avoid enabling jest with vitest plugin (#22499)
(camc314)
- 863984f linter/no-find-dom-node: Run on all files (#22479) (bab)

### ⚡ Performance

- 2afef79 linter: Optimize `no-loop-func` (#22491) (camchenry)
- 4c9ca72 oxlint: Align walker thread count with rayon pool (#22494)
(Boshen)

### 📚 Documentation

- f7967c7 linter/id-match: Clarify `onlyDeclarations` config docs
(#22523) (camc314)
- 1e0c97f linter: Fix closing code block in documentation for
`padding-around-after-all-blocks` rule. (#22513) (connorshea)
- a9049fd linter: Exclude directly provide autoFocus to dialog pattern
(#22510) (mehm8128)
# Oxfmt
### 🐛 Bug Fixes

- 8ee946f formatter/sort_imports: Use label to classify lines (#22512)
(leaysgur)
- 8c1da44 formatter: Normalize destructuring keys in DCR (#22478)
(camc314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camchenry camchenry camchenry approved these changes

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

@Sysix Sysix Awaiting requested review from Sysix

Assignees

@camchenry camchenry

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: jsx-a11y/no-autofocus should not report autofocus inside dialogs and popovers

4 participants

@mehm8128 @camchenry @Sysix @camc314