Skip to content

feat(linter): implement react no-unstable-nested-components#22248

Merged
camchenry merged 5 commits into
oxc-project:mainfrom
JoviDeCroock:impl-react-no-unstable-nested-components
May 16, 2026
Merged

feat(linter): implement react no-unstable-nested-components#22248
camchenry merged 5 commits into
oxc-project:mainfrom
JoviDeCroock:impl-react-no-unstable-nested-components

Conversation

@JoviDeCroock

Copy link
Copy Markdown
Contributor

Contributes to #1022

This implements the react/no-unstable-nested-components rule.

Note

This PR was authored by an LLM (GPT5.5) and reviewed by me

@JoviDeCroock JoviDeCroock requested a review from camc314 as a code owner May 8, 2026 06:26
@codspeed-hq

codspeed-hq Bot commented May 8, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1


Comparing JoviDeCroock:impl-react-no-unstable-nested-components (83b1cdd) with main (ddb6eed)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 added the A-linter Area - Linter label May 8, 2026
@JoviDeCroock JoviDeCroock force-pushed the impl-react-no-unstable-nested-components branch from 871b8fa to 59bda19 Compare May 8, 2026 19:30
Comment thread crates/oxc_linter/src/rules/react/no_unstable_nested_components.rs Outdated
Comment thread crates/oxc_linter/src/rules/react/no_unstable_nested_components.rs Outdated
@JoviDeCroock JoviDeCroock requested a review from camchenry May 10, 2026 05:59
@JoviDeCroock JoviDeCroock force-pushed the impl-react-no-unstable-nested-components branch 2 times, most recently from 04ac428 to deb7f34 Compare May 12, 2026 16:11
@camchenry camchenry self-assigned this May 12, 2026
@JoviDeCroock JoviDeCroock force-pushed the impl-react-no-unstable-nested-components branch from deb7f34 to 045b0b3 Compare May 15, 2026 07:38
@JoviDeCroock JoviDeCroock force-pushed the impl-react-no-unstable-nested-components branch from f019112 to 83b1cdd Compare May 15, 2026 08:59

@camchenry camchenry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camchenry camchenry merged commit 37680b0 into oxc-project:main May 16, 2026
28 checks passed
camc314 pushed a commit that referenced this pull request May 18, 2026
# Oxlint
### 🚀 Features

- 1ae291e linter/no-underscore-dangle: Add `allowInUsingDeclarations`
option (#22483) (吴杨帆)
- 0440b0f linter/eslint: Implement `id-match` rule (#22379) (Vladislav
Sayapin)
- 65bf119 linter: Implement react no-object-type-as-default-prop
(#22481) (uhyo)
- 2a6ddce linter/eslint: Implement `no-implied-eval` rule (#22391)
(Vladislav Sayapin)
- d3a3c1d linter: Auto detect agents from CLI and transition to the
agent output format (#22068) (Jovi De Croock)
- 625758a linter/vitest: Implement padding-around-after-all-blocks rule
(#21788) (kapobajza)
- 37680b0 linter: Implement react no-unstable-nested-components (#22248)
(Jovi De Croock)
- d8d9c74 linter: Implement import/newline-after-import rule (#19142)
(Ryuya Yanagi)

### 🐛 Bug Fixes

- 3f59e03 linter: Only call rayon/miette/tracing inits once (#21899)
(Matiss Janis Aboltins)
- 602dfd6 linter/promise/no-return-wrap: Detect Promise calls in all
branches (#22474) (zennnnnnn11)
- e182aee linter: Allow dialogs and popovers for no_autofocus (#22289)
(mehm8128)
- 7ffb710 linter/jest/vitest: Jest/no-standalone-expect ignores
additionalTestBlockFunctions option for jest/vitest hooks (#22477)
(kapobajza)
- c6f2d3f linter: Add more expression support for iframe-has-title
(#22460) (mehm8128)
- 5747ff1 linter: Avoid enabling jest with vitest plugin (#22499)
(camc314)
- 863984f linter/no-find-dom-node: Run on all files (#22479) (bab)

### ⚡ Performance

- 2afef79 linter: Optimize `no-loop-func` (#22491) (camchenry)
- 4c9ca72 oxlint: Align walker thread count with rayon pool (#22494)
(Boshen)

### 📚 Documentation

- f7967c7 linter/id-match: Clarify `onlyDeclarations` config docs
(#22523) (camc314)
- 1e0c97f linter: Fix closing code block in documentation for
`padding-around-after-all-blocks` rule. (#22513) (connorshea)
- a9049fd linter: Exclude directly provide autoFocus to dialog pattern
(#22510) (mehm8128)
# Oxfmt
### 🐛 Bug Fixes

- 8ee946f formatter/sort_imports: Use label to classify lines (#22512)
(leaysgur)
- 8c1da44 formatter: Normalize destructuring keys in DCR (#22478)
(camc314)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants