Skip to content

feat(allocator)!: remove Allocator::end_ptr method#21871

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-27-feat_allocator_remove_allocator_end_ptr_method
Apr 30, 2026
Merged

feat(allocator)!: remove Allocator::end_ptr method#21871
graphite-app[bot] merged 1 commit intomainfrom
om/04-27-feat_allocator_remove_allocator_end_ptr_method

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 27, 2026

Remove Allocator::end_ptr method. It's no longer required since #21869.

Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 27, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing om/04-27-feat_allocator_remove_allocator_end_ptr_method (0ffbe0d) with main (ce62f16)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (0ffbe0d) during the generation of this report, so ce62f16 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@overlookmotel overlookmotel marked this pull request as ready for review April 27, 2026 23:19
Copilot AI review requested due to automatic review settings April 27, 2026 23:19
@overlookmotel overlookmotel added C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior A-allocator Area - Allocator labels Apr 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the Allocator::end_ptr API from the raw-transfer-related methods, reflecting that it’s no longer needed after the allocator chunk metadata refactor introduced in #21869.

Changes:

  • Remove the Allocator::end_ptr method (and its documentation) from from_raw_parts-related APIs.
  • Update module-level docs to stop referencing Allocator::end_ptr.

@graphite-app graphite-app Bot force-pushed the om/04-27-refactor_napi_parser_avoid_converting_between_nonnull_and_raw_pointers branch from c2454c1 to 89d0315 Compare April 27, 2026 23:43
@graphite-app graphite-app Bot requested a review from camc314 as a code owner April 27, 2026 23:43
@graphite-app graphite-app Bot force-pushed the om/04-27-feat_allocator_remove_allocator_end_ptr_method branch from ff6e93f to ac3e6e6 Compare April 27, 2026 23:44
@overlookmotel overlookmotel force-pushed the om/04-27-refactor_napi_parser_avoid_converting_between_nonnull_and_raw_pointers branch from 89d0315 to af714fe Compare April 30, 2026 01:05
@overlookmotel overlookmotel force-pushed the om/04-27-feat_allocator_remove_allocator_end_ptr_method branch from ac3e6e6 to 7bc3af5 Compare April 30, 2026 01:05
@overlookmotel overlookmotel force-pushed the om/04-27-refactor_napi_parser_avoid_converting_between_nonnull_and_raw_pointers branch from af714fe to 4cec027 Compare April 30, 2026 01:18
@overlookmotel overlookmotel force-pushed the om/04-27-feat_allocator_remove_allocator_end_ptr_method branch from 7bc3af5 to 19eacf6 Compare April 30, 2026 01:18
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 30, 2026

Merge activity

Remove `Allocator::end_ptr` method. It's no longer required since #21869.
@graphite-app graphite-app Bot force-pushed the om/04-27-refactor_napi_parser_avoid_converting_between_nonnull_and_raw_pointers branch from 4cec027 to 245f813 Compare April 30, 2026 01:28
@graphite-app graphite-app Bot force-pushed the om/04-27-feat_allocator_remove_allocator_end_ptr_method branch from 19eacf6 to 0ffbe0d Compare April 30, 2026 01:29
Base automatically changed from om/04-27-refactor_napi_parser_avoid_converting_between_nonnull_and_raw_pointers to main April 30, 2026 01:33
@graphite-app graphite-app Bot merged commit 0ffbe0d into main Apr 30, 2026
36 of 37 checks passed
@graphite-app graphite-app Bot deleted the om/04-27-feat_allocator_remove_allocator_end_ptr_method branch April 30, 2026 01:34
camc314 added a commit that referenced this pull request May 5, 2026
### 💥 BREAKING CHANGES

- 0ffbe0d allocator: [**BREAKING**] Remove `Allocator::end_ptr` method
(#21871) (overlookmotel)

### 🚀 Features

- 9593ec8 transformer/jsx: Add jsxDEV source metadata for fragments
(#21932) (Ido Rosenthal)

### 🐛 Bug Fixes

- 429deac napi/parser: Export `visitorKeys` from `wasm` entrypoint
(#21996) (NullVoxPopuli)
- e852911 codegen: Preserve legal comments orphaned by upstream passes
(#21575) (Dunqing)
- e3399ec transformer/class-properties: Preserve RHS in
logical-assignment to static private field (#21950) (Dunqing)
- c59c199 transformer/typescript: Emit class fields for parameter
properties (#21831) (Dunqing)
- aaabde4 parser: Attach legal comments to following token (#21670)
(Dunqing)

### ⚡ Performance

- 0bf0cb9 allocator: Per-platform `Arena::new_fixed_size`
implementations (#22088) (overlookmotel)

### 📚 Documentation

- 62ec410 allocator: Correct doc comment for `Allocator::from_raw_parts`
(#22093) (overlookmotel)
- 3e152c6 allocator: Correct typos in comments (#22092) (overlookmotel)
- e220855 allocator: Correct doc comment for `Allocator::set_cursor_ptr`
(#21866) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: Cameron Clark <cameron.clark@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants