Skip to content

fix(napi/parser): export visitorKeys from wasm entrypoint#21996

Merged
camc314 merged 2 commits intooxc-project:mainfrom
NullVoxPopuli:nvp/issue-21995/add-visitorKeys-export
May 1, 2026
Merged

fix(napi/parser): export visitorKeys from wasm entrypoint#21996
camc314 merged 2 commits intooxc-project:mainfrom
NullVoxPopuli:nvp/issue-21995/add-visitorKeys-export

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

@NullVoxPopuli NullVoxPopuli commented Apr 30, 2026

Fixes #21995
Unblocks

Why?

  • getting the actual list of visitorKeys provides an optimization for tools like zimmerframe, which will walk over only the things specified in the visitorKeys list -- helping prevent accidental recursive visiting, which can happen when a tree adds parent referencs

@NullVoxPopuli NullVoxPopuli mentioned this pull request Apr 30, 2026
2 tasks
@camc314 camc314 changed the title Fix #21995 - add visitorKeys to browser runtime entrypoint for oxc-parser fix(napi/parser): export visitorKeys from wasm entrypoint Apr 30, 2026
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@camc314 camc314 self-assigned this May 1, 2026
@camc314 camc314 added the A-parser Area - Parser label May 1, 2026
@camc314 camc314 merged commit 429deac into oxc-project:main May 1, 2026
24 checks passed
camc314 added a commit that referenced this pull request May 5, 2026
### 💥 BREAKING CHANGES

- 0ffbe0d allocator: [**BREAKING**] Remove `Allocator::end_ptr` method
(#21871) (overlookmotel)

### 🚀 Features

- 9593ec8 transformer/jsx: Add jsxDEV source metadata for fragments
(#21932) (Ido Rosenthal)

### 🐛 Bug Fixes

- 429deac napi/parser: Export `visitorKeys` from `wasm` entrypoint
(#21996) (NullVoxPopuli)
- e852911 codegen: Preserve legal comments orphaned by upstream passes
(#21575) (Dunqing)
- e3399ec transformer/class-properties: Preserve RHS in
logical-assignment to static private field (#21950) (Dunqing)
- c59c199 transformer/typescript: Emit class fields for parameter
properties (#21831) (Dunqing)
- aaabde4 parser: Attach legal comments to following token (#21670)
(Dunqing)

### ⚡ Performance

- 0bf0cb9 allocator: Per-platform `Arena::new_fixed_size`
implementations (#22088) (overlookmotel)

### 📚 Documentation

- 62ec410 allocator: Correct doc comment for `Allocator::from_raw_parts`
(#22093) (overlookmotel)
- 3e152c6 allocator: Correct typos in comments (#22092) (overlookmotel)
- e220855 allocator: Correct doc comment for `Allocator::set_cursor_ptr`
(#21866) (overlookmotel)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: Cameron Clark <cameron.clark@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser variant of oxc-parser is mising visitorKeys

2 participants