refactor(napi/parser): avoid converting between NonNull and raw pointers#21870
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 30, 2026
Conversation
This was referenced Apr 27, 2026
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors napi/parser raw-transfer parsing to consistently use NonNull pointers (and pointer address APIs) instead of repeatedly converting between NonNull and raw *mut pointers, simplifying unsafe pointer handling.
Changes:
- Use
NonNull::from_mut(...).cast()for the buffer base pointer andNonNull::{add, addr}for offset/alignment checks. - Pass
NonNullpointers directly intoAllocator::from_raw_partsandAllocator::set_cursor_ptr(removingnew_uncheckedconversions). - Update pointer-alignment debug assertions to work with
NonNull::addr()’sNonZeroUsizereturn type.
2774b4a to
0d04ab0
Compare
0d04ab0 to
b83af4a
Compare
c2454c1 to
89d0315
Compare
b83af4a to
f4ed0be
Compare
89d0315 to
af714fe
Compare
af714fe to
4cec027
Compare
f4ed0be to
648e3c0
Compare
Contributor
Merge activity
|
…nters (#21870) Refactor. Simplify raw transfer code in `napi/parser`, by consistently using `NonNull` pointers, rather than converting back and forth between `NonNull` and `*mut` pointers.
648e3c0 to
99eef72
Compare
4cec027 to
245f813
Compare
Base automatically changed from
om/04-27-refactor_allocator_linter_plugins_napi_parser_store_raw_transfer_metadata_within_arena_chunk
to
main
April 30, 2026 01:32
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor. Simplify raw transfer code in
napi/parser, by consistently usingNonNullpointers, rather than converting back and forth betweenNonNulland*mutpointers.