Skip to content

refactor(linter): do not compile Linter::convert_and_call_external_linter on 32-bit or big endian#21963

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-30-refactor_linter_do_not_compile_linter_convert_and_call_external_linter_on_32-bit_or_big_endian
Apr 30, 2026
Merged

refactor(linter): do not compile Linter::convert_and_call_external_linter on 32-bit or big endian#21963
graphite-app[bot] merged 1 commit intomainfrom
om/04-30-refactor_linter_do_not_compile_linter_convert_and_call_external_linter_on_32-bit_or_big_endian

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 30, 2026 •
edited
Loading

This method is dead code on 32-bit or big endian platforms. Both callers are themselvs feature-gated to 64-bit little endian platforms already. So feature-gate this method too.

@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 30, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel self-assigned this Apr 30, 2026
@overlookmotel overlookmotel marked this pull request as ready for review April 30, 2026 00:43
@overlookmotel overlookmotel requested a review from camc314 as a code owner April 30, 2026 00:43
Copilot AI review requested due to automatic review settings April 30, 2026 00:43
Copilot AI reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens platform gating in oxc_linter by ensuring an internal helper used for JS-plugin external rules is only compiled on supported targets (64-bit little-endian), matching its already-gated callers.

Changes:

  • Add a #[cfg(all(target_pointer_width = "64", target_endian = "little"))] gate to Linter::convert_and_call_external_linter.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1

Comparing om/04-30-refactor_linter_do_not_compile_linter_convert_and_call_external_linter_on_32-bit_or_big_endian (a55635d) with main (ce62f16)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (a55635d) during the generation of this report, so ce62f16 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@overlookmotel overlookmotel added C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior A-linter-plugins Area - Linter JS plugins labels Apr 30, 2026
This was referenced Apr 30, 2026
Merged
Merged
Merged
Merged
Merged
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 30, 2026 •
edited
Loading

Merge activity

@overlookmotel
refactor(linter): do not compile `Linter::convert_and_call_external_l…
a55635d 
…inter` on 32-bit or big endian (#21963)

This method is dead code on 32-bit or big endian platforms. Both callers are themselvs feature-gated to 64-bit little endian platforms already. So feature-gate this method too.
@graphite-app graphite-app Bot force-pushed the om/04-30-refactor_linter_do_not_compile_linter_convert_and_call_external_linter_on_32-bit_or_big_endian branch from 3b67f17 to a55635d Compare April 30, 2026 01:27
@graphite-app graphite-app Bot merged commit a55635d into main Apr 30, 2026
27 checks passed
@graphite-app graphite-app Bot deleted the om/04-30-refactor_linter_do_not_compile_linter_convert_and_call_external_linter_on_32-bit_or_big_endian branch April 30, 2026 01:31
@Dunqing Dunqing mentioned this pull request May 7, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner

Assignees

@overlookmotel overlookmotel

Labels

A-linter-plugins Area - Linter JS plugins C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel