refactor(allocator): fix cast_sign_loss clippy warnings#21224
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
This was referenced Apr 9, 2026
Merging this PR will improve performance by 3.13%
Performance Changes
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors crates/oxc_allocator’s bump allocator implementation to address Clippy’s cast_sign_loss warning by scoping the lint suppression to the single, justified cast site instead of a file-wide blanket suppression.
Changes:
- Remove
clippy::cast_sign_lossfrom the file-level#![expect(...)]list. - Add a targeted
#[expect(clippy::cast_sign_loss, reason = ...)]on the specificoffset_from(..) as usizecast inChunkFooter::as_raw_parts.
Contributor
Merge activity
|
Continuation of #21210. Move an `#[expect(clippy::cast_sign_loss)]`attribute from blanket exclusion to a focused one at the location where this rule needs to be disabled, and add the reason why it's safe to ignore.
d449b29 to
9e58ecb
Compare
4276ffe to
145930f
Compare
Base automatically changed from
om/04-08-refactor_allocator_fix_cast_ptr_alignment_clippy_warnings
to
main
April 9, 2026 09:17
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #21210.
Move an
#[expect(clippy::cast_sign_loss)]attribute from blanket exclusion to a focused one at the location where this rule needs to be disabled, and add the reason why it's safe to ignore.