refactor(allocator): fix ptr_cast_constness clippy warnings#21222
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
This was referenced Apr 9, 2026
Member
Author
This was referenced Apr 9, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the allocator refactor in oxc_allocator by replacing raw pointer constness casts (as *const T / as *mut T) with the explicit pointer APIs (cast_const() / cast_mut()), aiming to eliminate clippy::ptr_cast_constness warnings and remove the corresponding #![expect(...)] entry.
Changes:
- Removed
clippy::ptr_cast_constnessfrom the file-level#![expect(...)]list. - Replaced
as *const u8casts inChunkFooter::as_raw_parts()withcast_const(). - Replaced one
as *mut u8cast inChunkRawIterwithcast_mut().
Comments suppressed due to low confidence (1)
crates/oxc_allocator/src/bump.rs:16
clippy::ptr_cast_constnesswas removed from the#![expect(...)]list, but there is still at least one raw-pointeras *const ...cast in this file (ChunkIter::nextusesptr as *const mem::MaybeUninit<u8>). Ifptr_cast_constnessis enabled in CI, this will reintroduce the clippy warning/error. Please update the remaining cast(s) to use the pointer casting APIs (e.g.cast::<T>()combined withcast_const()), or keep theexpectuntil all occurrences are eliminated.
#![expect(
clippy::cast_ptr_alignment,
clippy::cast_sign_loss,
clippy::inline_always,
clippy::missing_errors_doc,
clippy::missing_panics_doc,
clippy::mut_from_ref,
clippy::undocumented_unsafe_blocks,
clippy::unnecessary_safety_comment,
unsafe_op_in_unsafe_fn
)]
Contributor
Merge activity
|
Continuation of #21210. Replace `ptr as *const T` / `ptr as *mut T` with `ptr.cast_const()` / `ptr.cast_mut()`. This reveals one dodgy `const` to `mut` conversion in `ChunkRawIter`, which I'll address in a later PR.
0a8342d to
433d40b
Compare
f8dca2f to
af3fdeb
Compare
Base automatically changed from
om/04-08-refactor_allocator_fix_ptr_as_ptr_clippy_warnings
to
main
April 9, 2026 09:14
This was referenced Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #21210.
Replace
ptr as *const T/ptr as *mut Twithptr.cast_const()/ptr.cast_mut(). This reveals one dodgyconsttomutconversion inChunkRawIter, which I'll address in a later PR.