Skip to content

refactor(allocator): fix unused_self clippy warnings#21218

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_allocator_fix_unused_self_clippy_warnings
Apr 9, 2026
Merged

refactor(allocator): fix unused_self clippy warnings#21218
graphite-app[bot] merged 1 commit intomainfrom
om/04-08-refactor_allocator_fix_unused_self_clippy_warnings

Conversation

@overlookmotel
Copy link
Copy Markdown
Member

@overlookmotel overlookmotel commented Apr 9, 2026 •
edited
Loading

Continuation of #21210.

This was referenced Apr 9, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@overlookmotel Graphite App
Copy link
Copy Markdown
Member Author

overlookmotel commented Apr 9, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Apr 9, 2026
Merged
@github-actions github-actions Bot added A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 9, 2026
This was referenced Apr 9, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 9, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing om/04-08-refactor_allocator_fix_unused_self_clippy_warnings (137fa5f) with om/04-08-refactor_allocator_fix_manual_div_ceil_clippy_warnings (a9cfc37)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@overlookmotel overlookmotel marked this pull request as ready for review April 9, 2026 07:52
Copilot AI review requested due to automatic review settings April 9, 2026 07:52
Copilot AI reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the allocator refactor by addressing clippy::unused_self warnings in Bump while keeping the public API intact.

Changes:

  • Remove the file-level clippy::unused_self expect from bump.rs.
  • Add a targeted #[expect(clippy::unused_self)] on Bump::min_align().

Comment thread crates/oxc_allocator/src/bump.rs
@overlookmotel overlookmotel self-assigned this Apr 9, 2026
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Apr 9, 2026 •
edited
Loading

Merge activity

@graphite-app graphite-app Bot force-pushed the om/04-08-refactor_allocator_fix_manual_div_ceil_clippy_warnings branch from e690807 to a9cfc37 Compare April 9, 2026 08:49
@graphite-app graphite-app Bot force-pushed the om/04-08-refactor_allocator_fix_unused_self_clippy_warnings branch from cf2c68e to 137fa5f Compare April 9, 2026 08:50
Base automatically changed from om/04-08-refactor_allocator_fix_manual_div_ceil_clippy_warnings to main April 9, 2026 09:07
@graphite-app graphite-app Bot merged commit 137fa5f into main Apr 9, 2026
37 checks passed
@graphite-app graphite-app Bot deleted the om/04-08-refactor_allocator_fix_unused_self_clippy_warnings branch April 9, 2026 09:09
This was referenced Apr 9, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@overlookmotel overlookmotel

Labels

A-allocator Area - Allocator C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel