Skip to content

feat(parser): add VARIANTS const to Kind via fieldless_enum! macro#19877

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro
Mar 1, 2026
Merged

feat(parser): add VARIANTS const to Kind via fieldless_enum! macro#19877
graphite-app[bot] merged 1 commit intomainfrom
om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 1, 2026

Use the fieldless_enum! macro introduced in #19876 to add a VARIANTS const to Kind. This is required for raw transfer of tokens.

Copy link
Member Author

overlookmotel commented Mar 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review March 1, 2026 13:24
Copilot AI review requested due to automatic review settings March 1, 2026 13:24
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 1, 2026

Merging this PR will degrade performance by 4.31%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 51 untouched benchmarks
⏩ 3 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation estree_tokens_raw[checker.ts] 17.2 ms 15.6 ms +10.58%
Simulation mangler[RadixUIAdoptionSection.jsx_keep_names] 19.6 µs 20.5 µs -4.31%

Comparing om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro (ad5f1b4) with om/03-01-feat_data_structures_add_fieldless_enum_macro (0442a25)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on om/03-01-feat_data_structures_add_fieldless_enum_macro (b270112) during the generation of this report, so 1dd4762 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the parser’s lexer token kind (Kind) to use the newly introduced fieldless_enum! macro so Kind can expose a VARIANTS constant, enabling const-context iteration over all token kinds (needed for raw token transfer workflows).

Changes:

  • Replaces the Kind enum definition with a fieldless_enum! { ... } invocation to generate Kind::VARIANTS.
  • Enables the fieldless_enum feature on the oxc_data_structures dependency for oxc_parser.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
crates/oxc_parser/src/lexer/kind.rs Wraps Kind in fieldless_enum! so an associated VARIANTS constant is generated.
crates/oxc_parser/Cargo.toml Enables oxc_data_structures’s fieldless_enum feature to make the macro available.

@overlookmotel overlookmotel self-assigned this Mar 1, 2026
@overlookmotel overlookmotel added the A-linter-plugins Area - Linter JS plugins label Mar 1, 2026
@overlookmotel overlookmotel changed the base branch from om/03-01-feat_data_structures_add_fieldless_enum_macro to graphite-base/19877 March 1, 2026 16:04
@overlookmotel overlookmotel force-pushed the om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro branch from ad5f1b4 to 4efb610 Compare March 1, 2026 17:27
@overlookmotel overlookmotel changed the base branch from graphite-base/19877 to om/03-01-feat_data_structures_add_fieldless_enum_macro March 1, 2026 17:27
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
@overlookmotel overlookmotel force-pushed the om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro branch from 4efb610 to 3edfe90 Compare March 1, 2026 17:29
@overlookmotel overlookmotel force-pushed the om/03-01-feat_data_structures_add_fieldless_enum_macro branch from 9715ef3 to 904602d Compare March 1, 2026 17:29
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 1, 2026

Merge activity

…cro (#19877)

Use the `fieldless_enum!` macro introduced in #19876 to add a `VARIANTS` const to `Kind`. This is required for raw transfer of tokens.
@graphite-app graphite-app bot force-pushed the om/03-01-feat_data_structures_add_fieldless_enum_macro branch from 904602d to b3dceae Compare March 1, 2026 17:40
@graphite-app graphite-app bot force-pushed the om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro branch from 3edfe90 to ee4982b Compare March 1, 2026 17:40
Base automatically changed from om/03-01-feat_data_structures_add_fieldless_enum_macro to main March 1, 2026 17:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 1, 2026
@graphite-app graphite-app bot merged commit ee4982b into main Mar 1, 2026
23 checks passed
@graphite-app graphite-app bot deleted the om/03-01-feat_parser_add_variants_const_to_kind_via_fieldless_enum_macro branch March 1, 2026 17:47
camc314 pushed a commit that referenced this pull request Mar 2, 2026
### 🚀 Features

- 733d6dc parser: Report error on `infer` outside conditional type
(#19879) (camc314)
- c2a42f6 allocator: Add `Vec::into_bump_slice_mut` (#19895)
(overlookmotel)
- ee4982b parser: Add `VARIANTS` const to `Kind` via `fieldless_enum!`
macro (#19877) (overlookmotel)
- b3dceae data_structures: Add `fieldless_enum!` macro (#19876)
(overlookmotel)
- 12b841e parser: Make all `Kind::is_*` methods `const` (#19874)
(overlookmotel)
- 25c2e25 estree/tokens: Add function to update tokens in place (#19856)
(overlookmotel)
- f78e6df parser: Add `mutate_tokens` Cargo feature (#19853)
(overlookmotel)
- 5036bb6 parser: Report error on `for await` in static blocks (#19844)
(camc314)
- 42bd431 parser: Report error for missing initializer in using decl
(#19824) (camc314)
- a2f58e5 parser: Report error for `implements` clause in non-ts files
(#19820) (Cameron)
- b25228a estree: Add `IS_COMPACT` const to `Formatter` trait (#19787)
(overlookmotel)
- e2a1b79 estree: Expose buffer and formatter of serializers (#19773)
(overlookmotel)
- 4699498 data_structures: Add `CodeBuffer::print_strs_array` (#19760)
(overlookmotel)
- 233f947 estree: `oxc_estree` crate export config and formatter types
(#19724) (overlookmotel)
- 5937a32 semantic: Introduce `symbol_declarations` method (#19609)
(camc314)
- ea6b796 parser: Add `LexerConfig::TOKENS_METHOD_IS_STATIC` const
(#19683) (overlookmotel)
- 655c38f semantic: Add "did you mean?" suggestions to undefined name
errors (#19102) (copilot-swe-agent)
- 9e11dc6 parser,estree,coverage: Collect tokens in parser and convert
to ESTree format (#19497) (camc314)
- c4a3677 parser: Report error for initializer in ambient context
(#19187) (camc314)

### 🐛 Bug Fixes

- abc7e19 codegen: Improve parenthesised checks when printing types
(#19880) (camc314)
- 017de5d parser: Update error code for type annotation in `for...in`
statement (#19882) (camc314)
- 7682e5a linter/plugins: Decode escapes in identifier tokens (#19838)
(overlookmotel)
- 06767ed estree/tokens: Convert `this` tokens in `TSTypeName` (#19815)
(overlookmotel)
- ef798af parser: Use TS8037 for satisfies expression in JS files
diagnostic (#19819) (camc314)
- 98ea5c5 parser: Use TS8016 for type assertions in JS files diagnostic
(#19818) (camc314)
- 1710f56 codegen: Remove double indentation for enum inside namespace
(#19775) (Dunqing)
- 9e4995c codegen: Print type annotation on `CatchParameter` (#19790)
(camc314)
- 297b2bb codegen: Wrap `TSConditionalType` in parens when necessary
(#19788) (camc314)
- cec7878 codegen: Print `definite` property on AccessorProperty
(#19786) (camc314)
- 6f395cf codegen: Print `definite` property on PropertyDefinition
(#19785) (camc314)
- b749373 codegen: Correctly parenthesise TSArrayType (#19784) (camc314)
- 876dc1b codegen: Print object property `this` param (#19783) (camc314)
- 93bb861 formatter: Trim trailing whitespace before breaking line
(#19740) (leaysgur)
- ed17bbf codegen: Print `override` keyword for method and property
definitions (#19753) (Dunqing)
- 6a59a76 parser: Improve error recovery for private identifiers in
property names (#19710) (Boshen)
- 3b96f41 codegen: Print comments in JSX expression containers and
spread attributes (#19701) (Boshen)
- f5694ce estree/tokens: Reverse field order of `regex` object in tokens
(#19679) (overlookmotel)
- b2b7a55 estree/tokens: Generate tokens for files with BOM (#19535)
(overlookmotel)
- 50a7514 estree: Fix tokens for JSX (#19524) (overlookmotel)
- a35063e minifier: Preserve side effects for meta property url reads
(#19668) (Boshen)
- 8ad3430 semantic/jsdoc: Handle even-numbered backtick sequences in
JSDoc parsing (#19664) (Boshen)

### ⚡ Performance

- 05ccf9f linter/plugins: Transfer tokens via raw transfer (#19893)
(overlookmotel)
- c1bfdcf estree/tokens: Preallocate sufficient space for tokens JSON
(#19851) (overlookmotel)
- 4b0611a estree/tokens: Introduce `ESTreeTokenConfig` trait (#19842)
(overlookmotel)
- 81bab90 estree/tokens: Do not JSON-encode keyword, punctuator, etc
tokens (#19814) (overlookmotel)
- 6260ddd estree/tokens: Do not JSON-encode `this` identifiers (#19813)
(overlookmotel)
- b378f4a estree/tokens: Do not JSON-encode JSX identifiers (#19812)
(overlookmotel)
- 5016d92 estree/tokens: Handle regex tokens separately (#19796)
(overlookmotel)
- 780a68e estree/tokens: Use strings from AST for identifier tokens
(#19744) (overlookmotel)
- dc9c2e3 estree: Use `CodeBuffer::print_strs_array` to reduce bounds
checks (#19766) (overlookmotel)
- 845da35 estree: Use `CodeBuffer::print_indent` (#19727)
(overlookmotel)
- ec88f6a estree/tokens: Serialize tokens while visiting AST (#19726)
(overlookmotel)
- bc6507f estree/tokens: Serialize with `ESTree` not `serde` (#19725)
(overlookmotel)
- ec24859 estree/tokens: Do not branch on presence of override twice
(#19721) (overlookmotel)
- dac14be estree/tokens: Replace hash map with `Vec` (#19718)
(overlookmotel)
- b9d2443 estree/tokens: Replace multiple hash sets into a single hash
map (#19716) (overlookmotel)
- 7233548 parser: Remove branches from `finish_next_inner` (#19695)
(overlookmotel)
- b5d9845 parser: Remove const generic param from `finish_next_inner`
(#19684) (overlookmotel)
- 8940f66 estree/tokens: Serialize tokens to compact JSON (#19572)
(overlookmotel)
- 136e39b parser/tokens: Pre-allocate capacity for tokens (#19543)
(overlookmotel)
- 6a6513c linter/plugins: Use Oxc tokens in plugins (#19498) (camc314)
- b3b2d30 parser: Introduce `ParserConfig` (#19637) (overlookmotel)

### 📚 Documentation

- b2b7a64 estree/tokens: Correct comment (#19873) (overlookmotel)
- 0399311 estree/tokens: Improve comments (#19836) (overlookmotel)
- 1b392de minifier: Add `Function.prototype.toString` assumption
(#19758) (sapphi-red)
- 75c9cd8 parser: Improve doc comments for `ParserConfig` and
`LexerConfig` (#19682) (overlookmotel)
- 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter-plugins Area - Linter JS plugins A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants