refactor(estree/tokens): add Context methods from different AST nodes#19867
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 1, 2026
Conversation
Member
Author
Context methods take AST nodesContext methods from different AST nodes
This was referenced Mar 1, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxc_estree_tokens’ internal Context interface to provide node-specific emission methods (e.g., PrivateIdentifier, StringLiteral, JSXText), improving clarity around when token kinds need mutation in raw-transfer mode versus when JSON serialization needs JSON-escaping.
Changes:
- Replace
*_at(start, …, TokenType)-style APIs with node-specificContextmethods (removingTokenTypefrom the trait). - Split handling for
StringLiteralvsStringLiteral-as-JSXTextvs actualJSXTextto make raw-transfer kind overrides explicit. - Update
Visitor,JsonContext, andRawContextto use the newContextmethods.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_estree_tokens/src/visitor.rs | Updates AST visitor to call the new node-specific Context emission methods. |
| crates/oxc_estree_tokens/src/raw_transfer.rs | Adapts raw-transfer context to new APIs; keeps no-op behavior where token kinds already match, and sets Kind::JSXText only for JSX-attribute string literals. |
| crates/oxc_estree_tokens/src/json.rs | Moves TokenType usage fully into JSON serialization; adds small internal helpers and implements new Context methods. |
| crates/oxc_estree_tokens/src/context.rs | Refactors the Context trait signatures and documentation to match the new node-specific emission approach. |
This was referenced Mar 1, 2026
c919ce9 to
28983f9
Compare
ce89e1d to
b6f81a4
Compare
Member
Author
Merge activity
|
b6f81a4 to
73aa87e
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
…es (#19867) Refactor. Create individual `Context` methods for different AST node types. * Clarifies the logic around `JSXText` tokens - when they need updating and when they don't. * Removes `TokenType` from `Context` methods' signatures. `TokenType` is now specific to JSON serialization.
28983f9 to
43eb95f
Compare
…es (#19867) Refactor. Create individual `Context` methods for different AST node types. * Clarifies the logic around `JSXText` tokens - when they need updating and when they don't. * Removes `TokenType` from `Context` methods' signatures. `TokenType` is now specific to JSON serialization.
73aa87e to
bb87d80
Compare
43eb95f to
1d7adf0
Compare
Base automatically changed from
om/03-01-refactor_estree_tokens_rename_updatecontext_to_rawcontext_
to
main
March 1, 2026 16:57
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor. Create individual
Contextmethods for different AST node types.JSXTexttokens - when they need updating and when they don't.TokenTypefromContextmethods' signatures.TokenTypeis now specific to JSON serialization.