refactor(estree/tokens): break up into multiple files#19865
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 1, 2026
Merged
Conversation
This was referenced Mar 1, 2026
Member
Author
This was referenced Mar 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the oxc_estree_tokens crate by splitting the former monolithic serialize.rs into smaller, purpose-focused modules (JSON serialization, in-place raw transfer update, shared visitor/context utilities) while keeping the token-walking and emission logic equivalent.
Changes:
- Split token serialization / update logic into
json.rs,raw_transfer.rs,context.rs, andvisitor.rs. - Reworked
lib.rsto expose the same public entry points via re-exports. - Added/updated module-level documentation headers across the new/updated files.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/oxc_estree_tokens/src/visitor.rs | New AST visitor module extracted from former serialize.rs. |
| crates/oxc_estree_tokens/src/context.rs | New shared Context trait module used by both JSON and raw-transfer modes. |
| crates/oxc_estree_tokens/src/json.rs | New JSON serialization implementation extracted from former serialize.rs. |
| crates/oxc_estree_tokens/src/raw_transfer.rs | New in-place token kind update implementation extracted from former serialize.rs. |
| crates/oxc_estree_tokens/src/lib.rs | Updates module structure and re-exports public API entry points. |
| crates/oxc_estree_tokens/src/options.rs | Adjusts imports and adds module docs. |
| crates/oxc_estree_tokens/src/jsx_state.rs | Adds module docs. |
| crates/oxc_estree_tokens/src/token_type.rs | Adds module docs. |
| crates/oxc_estree_tokens/src/u32_string.rs | Adds module docs. |
| crates/oxc_estree_tokens/src/serialize.rs | Removed (functionality redistributed into new modules). |
This was referenced Mar 1, 2026
Merging this PR will not alter performance
Comparing 
Footnotes
|
This was referenced Mar 1, 2026
8581850 to
43875e0
Compare
4854bfd to
32675fd
Compare
Contributor
Merge activity
|
32675fd to
a3b01a2
Compare
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
Pure refactor. `serialize.rs` had got too big. Split it up into different files. Does not alter any of the code, just moves it into separate files.
43875e0 to
53af931
Compare
Pure refactor. `serialize.rs` had got too big. Split it up into different files. Does not alter any of the code, just moves it into separate files.
a3b01a2 to
25c2e25
Compare
53af931 to
442b0b9
Compare
Base automatically changed from
om/02-28-feat_estree_tokens_add_function_to_update_tokens_in_place
to
main
March 1, 2026 16:55
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
serialize.rshad got too big. Split it up into different files. Does not alter any of the code, just moves it into separate files.