fix(parser): improve error recovery for private identifiers in property names by Boshen · Pull Request #19710 · oxc-project/oxc

Boshen · 2026-02-25T11:41:04Z

Summary

When #ident appears as a property key in invalid positions (object literals {#x: 1}, destructuring const {#x} = y, TS interface members), the parser previously fell into parse_identifier_name() producing an unhelpful "Unexpected token" error
Added a Kind::PrivateIdentifier arm in parse_property_name() that creates a proper PropertyKey::PrivateIdentifier AST node and emits "Private identifier '#x' is not allowed in property names"
This works correctly both inside and outside class bodies, with no conformance regressions

closes #19669

🤖 Generated with Claude Code

Copilot

Pull request overview

This PR improves parser error recovery when private identifiers appear in invalid property name positions. Previously, encountering #ident as a property key in object literals ({#x: 1}), destructuring patterns (const {#x} = y), or TypeScript interface members would cause the parser to produce a generic "Unexpected token" error. The fix adds a specific handler in parse_property_name() that creates a proper PropertyKey::PrivateIdentifier AST node and emits a clear, descriptive error message.

Changes:

Added a Kind::PrivateIdentifier case handler in parse_property_name() that emits a specific error message
Created a new diagnostic function private_identifier_in_property_name() that provides clear feedback about the syntax error
Updated test snapshots to reflect the improved error messages across TypeScript, Test262, and Babel test suites

Reviewed changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/oxc_parser/src/js/object.rs	Added `Kind::PrivateIdentifier` handler to `parse_property_name()` that creates proper AST node and emits descriptive error
crates/oxc_parser/src/diagnostics.rs	Added `private_identifier_in_property_name()` diagnostic function for the new error message
tasks/coverage/snapshots/parser_typescript.snap	Updated snapshots showing improved error messages for private identifiers in TS interfaces and type literals
tasks/coverage/snapshots/parser_test262.snap	Updated snapshots showing improved error messages for private identifiers in object methods and destructuring
tasks/coverage/snapshots/parser_babel.snap	Updated snapshots showing improved error messages for private identifiers in Babel test fixtures

Boshen · 2026-02-25T11:46:54Z

Merge activity

Feb 25, 11:46 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Feb 25, 11:48 AM UTC: Boshen added this pull request to the Graphite merge queue.
Feb 25, 11:55 AM UTC: Merged by the Graphite merge queue.

codspeed-hq · 2026-02-25T11:48:51Z

Merging this PR will not alter performance

✅ 52 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing fix/parser-private-identifier-error-recovery (1c100c1) with main (ecf1699)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…ty names (#19710) ## Summary - When `#ident` appears as a property key in invalid positions (object literals `{#x: 1}`, destructuring `const {#x} = y`, TS interface members), the parser previously fell into `parse_identifier_name()` producing an unhelpful "Unexpected token" error - Added a `Kind::PrivateIdentifier` arm in `parse_property_name()` that creates a proper `PropertyKey::PrivateIdentifier` AST node and emits "Private identifier '#x' is not allowed in property names" - This works correctly both inside and outside class bodies, with no conformance regressions closes #19669 🤖 Generated with [Claude Code](https://claude.com/claude-code)

### 🚀 Features - 733d6dc parser: Report error on `infer` outside conditional type (#19879) (camc314) - c2a42f6 allocator: Add `Vec::into_bump_slice_mut` (#19895) (overlookmotel) - ee4982b parser: Add `VARIANTS` const to `Kind` via `fieldless_enum!` macro (#19877) (overlookmotel) - b3dceae data_structures: Add `fieldless_enum!` macro (#19876) (overlookmotel) - 12b841e parser: Make all `Kind::is_*` methods `const` (#19874) (overlookmotel) - 25c2e25 estree/tokens: Add function to update tokens in place (#19856) (overlookmotel) - f78e6df parser: Add `mutate_tokens` Cargo feature (#19853) (overlookmotel) - 5036bb6 parser: Report error on `for await` in static blocks (#19844) (camc314) - 42bd431 parser: Report error for missing initializer in using decl (#19824) (camc314) - a2f58e5 parser: Report error for `implements` clause in non-ts files (#19820) (Cameron) - b25228a estree: Add `IS_COMPACT` const to `Formatter` trait (#19787) (overlookmotel) - e2a1b79 estree: Expose buffer and formatter of serializers (#19773) (overlookmotel) - 4699498 data_structures: Add `CodeBuffer::print_strs_array` (#19760) (overlookmotel) - 233f947 estree: `oxc_estree` crate export config and formatter types (#19724) (overlookmotel) - 5937a32 semantic: Introduce `symbol_declarations` method (#19609) (camc314) - ea6b796 parser: Add `LexerConfig::TOKENS_METHOD_IS_STATIC` const (#19683) (overlookmotel) - 655c38f semantic: Add "did you mean?" suggestions to undefined name errors (#19102) (copilot-swe-agent) - 9e11dc6 parser,estree,coverage: Collect tokens in parser and convert to ESTree format (#19497) (camc314) - c4a3677 parser: Report error for initializer in ambient context (#19187) (camc314) ### 🐛 Bug Fixes - abc7e19 codegen: Improve parenthesised checks when printing types (#19880) (camc314) - 017de5d parser: Update error code for type annotation in `for...in` statement (#19882) (camc314) - 7682e5a linter/plugins: Decode escapes in identifier tokens (#19838) (overlookmotel) - 06767ed estree/tokens: Convert `this` tokens in `TSTypeName` (#19815) (overlookmotel) - ef798af parser: Use TS8037 for satisfies expression in JS files diagnostic (#19819) (camc314) - 98ea5c5 parser: Use TS8016 for type assertions in JS files diagnostic (#19818) (camc314) - 1710f56 codegen: Remove double indentation for enum inside namespace (#19775) (Dunqing) - 9e4995c codegen: Print type annotation on `CatchParameter` (#19790) (camc314) - 297b2bb codegen: Wrap `TSConditionalType` in parens when necessary (#19788) (camc314) - cec7878 codegen: Print `definite` property on AccessorProperty (#19786) (camc314) - 6f395cf codegen: Print `definite` property on PropertyDefinition (#19785) (camc314) - b749373 codegen: Correctly parenthesise TSArrayType (#19784) (camc314) - 876dc1b codegen: Print object property `this` param (#19783) (camc314) - 93bb861 formatter: Trim trailing whitespace before breaking line (#19740) (leaysgur) - ed17bbf codegen: Print `override` keyword for method and property definitions (#19753) (Dunqing) - 6a59a76 parser: Improve error recovery for private identifiers in property names (#19710) (Boshen) - 3b96f41 codegen: Print comments in JSX expression containers and spread attributes (#19701) (Boshen) - f5694ce estree/tokens: Reverse field order of `regex` object in tokens (#19679) (overlookmotel) - b2b7a55 estree/tokens: Generate tokens for files with BOM (#19535) (overlookmotel) - 50a7514 estree: Fix tokens for JSX (#19524) (overlookmotel) - a35063e minifier: Preserve side effects for meta property url reads (#19668) (Boshen) - 8ad3430 semantic/jsdoc: Handle even-numbered backtick sequences in JSDoc parsing (#19664) (Boshen) ### ⚡ Performance - 05ccf9f linter/plugins: Transfer tokens via raw transfer (#19893) (overlookmotel) - c1bfdcf estree/tokens: Preallocate sufficient space for tokens JSON (#19851) (overlookmotel) - 4b0611a estree/tokens: Introduce `ESTreeTokenConfig` trait (#19842) (overlookmotel) - 81bab90 estree/tokens: Do not JSON-encode keyword, punctuator, etc tokens (#19814) (overlookmotel) - 6260ddd estree/tokens: Do not JSON-encode `this` identifiers (#19813) (overlookmotel) - b378f4a estree/tokens: Do not JSON-encode JSX identifiers (#19812) (overlookmotel) - 5016d92 estree/tokens: Handle regex tokens separately (#19796) (overlookmotel) - 780a68e estree/tokens: Use strings from AST for identifier tokens (#19744) (overlookmotel) - dc9c2e3 estree: Use `CodeBuffer::print_strs_array` to reduce bounds checks (#19766) (overlookmotel) - 845da35 estree: Use `CodeBuffer::print_indent` (#19727) (overlookmotel) - ec88f6a estree/tokens: Serialize tokens while visiting AST (#19726) (overlookmotel) - bc6507f estree/tokens: Serialize with `ESTree` not `serde` (#19725) (overlookmotel) - ec24859 estree/tokens: Do not branch on presence of override twice (#19721) (overlookmotel) - dac14be estree/tokens: Replace hash map with `Vec` (#19718) (overlookmotel) - b9d2443 estree/tokens: Replace multiple hash sets into a single hash map (#19716) (overlookmotel) - 7233548 parser: Remove branches from `finish_next_inner` (#19695) (overlookmotel) - b5d9845 parser: Remove const generic param from `finish_next_inner` (#19684) (overlookmotel) - 8940f66 estree/tokens: Serialize tokens to compact JSON (#19572) (overlookmotel) - 136e39b parser/tokens: Pre-allocate capacity for tokens (#19543) (overlookmotel) - 6a6513c linter/plugins: Use Oxc tokens in plugins (#19498) (camc314) - b3b2d30 parser: Introduce `ParserConfig` (#19637) (overlookmotel) ### 📚 Documentation - b2b7a64 estree/tokens: Correct comment (#19873) (overlookmotel) - 0399311 estree/tokens: Improve comments (#19836) (overlookmotel) - 1b392de minifier: Add `Function.prototype.toString` assumption (#19758) (sapphi-red) - 75c9cd8 parser: Improve doc comments for `ParserConfig` and `LexerConfig` (#19682) (overlookmotel) - 2fa936f README.md: Map npm package links to npmx.dev (#19666) (Boshen) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 25, 2026 11:41

github-actions bot added A-parser Area - Parser C-bug Category - Bug labels Feb 25, 2026

Copilot started reviewing on behalf of Boshen February 25, 2026 11:41 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 25, 2026

graphite-app bot force-pushed the fix/parser-private-identifier-error-recovery branch from 1c100c1 to 6a59a76 Compare February 25, 2026 11:49

graphite-app bot merged commit 6a59a76 into main Feb 25, 2026
22 checks passed

graphite-app bot deleted the fix/parser-private-identifier-error-recovery branch February 25, 2026 11:55

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 25, 2026

Boshen mentioned this pull request Mar 2, 2026

release(crates): oxc v0.116.0 #19911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(parser): improve error recovery for private identifiers in property names#19710

fix(parser): improve error recovery for private identifiers in property names#19710
graphite-app[bot] merged 1 commit intomainfrom
fix/parser-private-identifier-error-recovery

Boshen commented Feb 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Boshen commented Feb 25, 2026 •

edited by graphite-app bot

Loading

Uh oh!

codspeed-hq bot commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Boshen commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Boshen commented Feb 25, 2026 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

codspeed-hq bot commented Feb 25, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Boshen commented Feb 25, 2026 •

edited

Loading

Boshen commented Feb 25, 2026 •

edited by graphite-app bot

Loading