Skip to content

feat(linter): introduce debug assertions after fixes to assert validity#15389

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity
Nov 6, 2025
Merged

feat(linter): introduce debug assertions after fixes to assert validity#15389
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 6, 2025 •
edited
Loading

ref #14833

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 6, 2025
@camc314 camc314 marked this pull request as ready for review November 6, 2025 16:08
This was referenced Nov 6, 2025
Merged
Merged
Merged
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15389 will not alter performance

Comparing c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity (2a89b43) with main (dac2a9c)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (2a89b43) during the generation of this report, so dac2a9c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity branch from 2870c35 to 3ddd035 Compare November 6, 2025 17:03
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 force-pushed the c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity branch from 3ddd035 to 71fb215 Compare November 6, 2025 17:04
@camc314 camc314 force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 6cf27f1 to e7ebbd3 Compare November 6, 2025 17:04
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2025 •
edited
Loading

Merge activity

@graphite-app graphite-app bot force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from e7ebbd3 to ddd9f9f Compare November 6, 2025 17:10
@graphite-app graphite-app bot force-pushed the c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity branch from 71fb215 to 2a89b43 Compare November 6, 2025 17:10
Base automatically changed from c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions to main November 6, 2025 17:14
@graphite-app graphite-app bot merged commit 2a89b43 into main Nov 6, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/11-06-feat_linter_introduce_debug_assertions_after_fixes_to_assert_validity branch November 6, 2025 17:15
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314