Skip to content

fix(linter/no-template-curly-in-string): remove fixer#15387

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-fix_linter_no-template-curly-in-string_remove_fixer
Nov 6, 2025
Merged

fix(linter/no-template-curly-in-string): remove fixer#15387
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-fix_linter_no-template-curly-in-string_remove_fixer

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 6, 2025 •
edited
Loading

The fixer is just too unreliable here, and it's too easy for it to generate invalid syntax/code.

We don't check to see if the content between the ${​ and }​ is valid, if is't not, is causes an invalid syntax tree.

@camc314 camc314 marked this pull request as ready for review November 6, 2025 15:44
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 6, 2025
@camc314 camc314 mentioned this pull request Nov 6, 2025
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 6, 2025
Merged
Merged
Base automatically changed from c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ to main November 6, 2025 15:45
Copilot AI review requested due to automatic review settings November 6, 2025 15:48
@camc314 camc314 force-pushed the c/11-06-fix_linter_no-template-curly-in-string_remove_fixer branch from 810777f to 9745e86 Compare November 6, 2025 15:48
Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the dangerous fix capability from the no-template-curly-in-string ESLint rule, converting it from a rule that auto-fixes violations to one that only reports diagnostics.

  • Removed dangerous_fix from the rule declaration
  • Replaced ctx.diagnostic_with_dangerous_fix() with ctx.diagnostic() to report violations without providing fixes
  • Removed test fixtures for fix validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314
fix(linter/no-template-curly-in-string): remove fixer (#15387)
dac2a9c 
The fixer is just too unreliable here, and it's too easy for it to generate invalid syntax/code.

We don't check to see if the content between the `${`​ and `}`​ is valid, if is't not, is causes an invalid syntax tree.
@graphite-app graphite-app bot force-pushed the c/11-06-fix_linter_no-template-curly-in-string_remove_fixer branch from 9745e86 to dac2a9c Compare November 6, 2025 15:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2025

Merge activity

@graphite-app graphite-app bot merged commit dac2a9c into main Nov 6, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/11-06-fix_linter_no-template-curly-in-string_remove_fixer branch November 6, 2025 15:58
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #15387 will not alter performance

Comparing c/11-06-fix_linter_no-template-curly-in-string_remove_fixer (dac2a9c) with main (77b603e)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (dac2a9c) during the generation of this report, so 77b603e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This was referenced Nov 6, 2025
Merged
Closed
@Boshen Boshen mentioned this pull request Nov 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314