fix(linter/forward-ref-uses-ref): dont suggest removing wrapper in invalid positions by camc314 · Pull Request #15388 · oxc-project/oxc

camc314 · 2025-11-06T15:44:01Z

camc314 · 2025-11-06T15:44:17Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs

codspeed-hq · 2025-11-06T15:57:48Z

CodSpeed Performance Report

Merging #15388 will not alter performance

_{Comparing c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions (ddd9f9f) with main (dac2a9c)¹}

Summary

✅ 4 untouched
⏩ 33 skipped²

No successful run was found on main (ddd9f9f) during the generation of this report, so dac2a9c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Copilot

Pull Request Overview

This PR improves the forward_ref_uses_ref rule by conditionally offering fix suggestions based on the context of anonymous function expressions. When an anonymous function expression is used in a statement context (e.g., forwardRef(function(a) {})), removing the forwardRef wrapper would result in invalid syntax, so only the "add ref parameter" fix is offered. For other cases (arrow functions, named function expressions, or anonymous functions in expression contexts), both fixes are provided.

Added logic to detect when removing forwardRef would be unsafe
Extracted the "add ref parameter" fix into a reusable closure
Updated test cases to reflect the new conditional fix behavior

Comments suppressed due to low confidence (1)

crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs:15

The help message suggests both fixes are always available ('Add a ref parameter, or remove forwardRef'), but the code now conditionally provides only the add-ref fix in some cases. Consider making the help message dynamic or more general to avoid misleading users when only one fix is available.

        .with_help("Add a `ref` parameter, or remove `forwardRef`")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs

graphite-app · 2025-11-06T17:09:44Z

Merge activity

Nov 6, 5:09 PM UTC: camc314 added this pull request to the Graphite merge queue.
Nov 6, 5:14 PM UTC: Merged by the Graphite merge queue.

…valid positions (#15388) fixes #15384

camc314 marked this pull request as ready for review November 6, 2025 15:44

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Nov 6, 2025

This was referenced Nov 6, 2025

fix(linter/no-var): only fix to const if the var has an initializer #15385

Merged

style(linter/forward-ref-uses-ref): move Rule trait impl directly below declare_oxc_linter #15386

Merged

camc314 mentioned this pull request Nov 6, 2025

fix(linter/no-template-curly-in-string): remove fixer #15387

Merged

camc314 force-pushed the c/11-06-fix_linter_no-template-curly-in-string_remove_fixer branch from 810777f to 9745e86 Compare November 6, 2025 15:48

camc314 force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 880ee63 to 8641b47 Compare November 6, 2025 15:48

graphite-app bot reviewed Nov 6, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs Outdated Show resolved Hide resolved

graphite-app bot changed the base branch from c/11-06-fix_linter_no-template-curly-in-string_remove_fixer to graphite-base/15388 November 6, 2025 15:53

graphite-app bot force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 8641b47 to 2db4f2c Compare November 6, 2025 15:59

graphite-app bot force-pushed the graphite-base/15388 branch from 9745e86 to dac2a9c Compare November 6, 2025 15:59

graphite-app bot changed the base branch from graphite-base/15388 to main November 6, 2025 15:59

graphite-app bot force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 2db4f2c to 816a762 Compare November 6, 2025 15:59

Copilot AI review requested due to automatic review settings November 6, 2025 16:07

camc314 force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 816a762 to 6cf27f1 Compare November 6, 2025 16:07

Copilot AI reviewed Nov 6, 2025

View reviewed changes

crates/oxc_linter/src/rules/react/forward_ref_uses_ref.rs Outdated Show resolved Hide resolved

camc314 mentioned this pull request Nov 6, 2025

feat(linter): introduce debug assertions after fixes to assert validity #15389

Merged

camc314 force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from 6cf27f1 to e7ebbd3 Compare November 6, 2025 17:04

fix(linter/forward-ref-uses-ref): dont suggest removing wrapper in in…

ddd9f9f

…valid positions (#15388) fixes #15384

graphite-app bot force-pushed the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch from e7ebbd3 to ddd9f9f Compare November 6, 2025 17:10

graphite-app bot merged commit ddd9f9f into main Nov 6, 2025
20 checks passed

graphite-app bot deleted the c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions branch November 6, 2025 17:14

Boshen mentioned this pull request Nov 10, 2025

release(apps): oxlint v1.27.0 && oxfmt v0.12.0 #15547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter/forward-ref-uses-ref): dont suggest removing wrapper in invalid positions#15388

fix(linter/forward-ref-uses-ref): dont suggest removing wrapper in invalid positions#15388
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-fix_linter_forward-ref-uses-ref_dont_suggest_removing_wrapper_in_invalid_positions

camc314 commented Nov 6, 2025 •

edited

Loading

Uh oh!

camc314 commented Nov 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

codspeed-hq bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

codspeed-hq bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #15388 will not alter performance

Summary

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

graphite-app bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Nov 6, 2025 •

edited

Loading

camc314 commented Nov 6, 2025 •

edited

Loading

codspeed-hq bot commented Nov 6, 2025 •

edited

Loading

graphite-app bot commented Nov 6, 2025 •

edited

Loading