Skip to content

style(linter/forward-ref-uses-ref): move Rule trait impl directly below declare_oxc_linter#15386

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_
Nov 6, 2025
Merged

style(linter/forward-ref-uses-ref): move Rule trait impl directly below declare_oxc_linter#15386
graphite-app[bot] merged 1 commit intomainfrom
c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 6, 2025

No description provided.

@github-actions github-actions bot added the A-linter Area - Linter label Nov 6, 2025
@camc314 camc314 mentioned this pull request Nov 6, 2025
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 6, 2025
@graphite-app graphite-app bot changed the base branch from c/11-06-fix_linter_no-var_only_fix_to_const_if_the_var_has_an_initializer to graphite-base/15386 November 6, 2025 15:26
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15386 will not alter performance

Comparing c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ (77b603e) with main (989b8e3)1

Summary

✅ 4 untouched
⏩ 33 skipped2

Footnotes

  1. No successful run was found on main (77b603e) during the generation of this report, so 989b8e3 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 33 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@graphite-app graphite-app bot force-pushed the c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ branch from 4637f0e to 66294ec Compare November 6, 2025 15:32
@graphite-app graphite-app bot force-pushed the graphite-base/15386 branch from 4de0f23 to 989b8e3 Compare November 6, 2025 15:32
@graphite-app graphite-app bot changed the base branch from graphite-base/15386 to main November 6, 2025 15:32
@graphite-app graphite-app bot force-pushed the c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ branch from 66294ec to 14cec97 Compare November 6, 2025 15:33
@camc314 camc314 marked this pull request as ready for review November 6, 2025 15:39
Copilot AI review requested due to automatic review settings November 6, 2025 15:39
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 6, 2025 •
edited
Loading

Merge activity

Copilot AI reviewed Nov 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes the implementation order in the forward_ref_uses_ref.rs file by moving the Rule trait implementation for ForwardRefUsesRef to appear immediately after the rule declaration, before the helper function check_forward_ref_inner. This improves code organization by placing the main rule implementation closer to its declaration, making the file structure more intuitive to read.

  • Moved impl Rule for ForwardRefUsesRef block from after check_forward_ref_inner to immediately after the rule declaration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ branch from 14cec97 to 77b603e Compare November 6, 2025 15:40
This was referenced Nov 6, 2025
Merged
Merged
@graphite-app graphite-app bot merged commit 77b603e into main Nov 6, 2025
20 checks passed
@graphite-app graphite-app bot deleted the c/11-06-style_linter_forward-ref-uses-ref_move_rule_trait_impl_directly_below_declare_oxc_linter_ branch November 6, 2025 15:45
@camc314 camc314 mentioned this pull request Nov 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314