Skip to content

refactor(perf): optimize cases with no child referrers in recursiveCopy#1729

Merged
qweeah merged 16 commits into
oras-project:mainfrom
qweeah:qweeah/fix-cp
May 13, 2025
Merged

refactor(perf): optimize cases with no child referrers in recursiveCopy#1729
qweeah merged 16 commits into
oras-project:mainfrom
qweeah:qweeah/fix-cp

Conversation

@qweeah

@qweeah qweeah commented May 12, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR improves the recursiveCopy function to handle cases where there are no child manifests or referrers, ensuring the function exits early in such scenarios. This change improves the function's efficiency and robustness.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov

codecov Bot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (457e342) to head (28a37d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/root/cp.go 88.09% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
+ Coverage   84.92%   85.17%   +0.24%     
==========================================
  Files         129      129              
  Lines        5751     5766      +15     
==========================================
+ Hits         4884     4911      +27     
+ Misses        617      609       -8     
+ Partials      250      246       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qweeah qweeah marked this pull request as draft May 12, 2025 09:24
@qweeah qweeah marked this pull request as ready for review May 12, 2025 10:24
qweeah and others added 13 commits May 13, 2025 01:31
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…sition

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…a6126986d9 to 2.6.0 (oras-project#1725)

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…cenarios

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…marshal failures

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
…ilures

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Comment thread cmd/oras/root/cp.go Outdated
Comment thread cmd/oras/root/cp.go
…e errors correctly

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah merged commit dbc56a9 into oras-project:main May 13, 2025
8 checks passed
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants