Skip to content

fix: discover handler errors for lint#1677

Merged
TerryHowe merged 3 commits into
oras-project:mainfrom
TerryHowe:lint-error-return-failures
May 12, 2025
Merged

fix: discover handler errors for lint#1677
TerryHowe merged 3 commits into
oras-project:mainfrom
TerryHowe:lint-error-return-failures

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

New lint fails without this better error handling. Actually pay attention to some error returns and ignore others.

@codecov

codecov Bot commented Mar 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (b06197d) to head (df8d3e8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1677      +/-   ##
==========================================
+ Coverage   84.81%   84.92%   +0.11%     
==========================================
  Files         127      128       +1     
  Lines        5722     5751      +29     
==========================================
+ Hits         4853     4884      +31     
+ Misses        619      617       -2     
  Partials      250      250              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cmd/oras/internal/display/metadata/table/discover.go
Comment thread cmd/oras/internal/option/packer.go Outdated
Comment thread cmd/oras/internal/option/format.go
Comment thread cmd/oras/root/push.go Outdated
@TerryHowe TerryHowe force-pushed the lint-error-return-failures branch from d3e4cb1 to 5531de0 Compare April 2, 2025 10:12
@TerryHowe TerryHowe changed the title fix: handle important error returns for lint fix: discover handler errors for lint Apr 2, 2025
@TerryHowe TerryHowe force-pushed the lint-error-return-failures branch from 086e7ba to 4469fc1 Compare May 5, 2025 12:19
Comment thread cmd/oras/internal/display/metadata/table/discover_test.go Outdated
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the lint-error-return-failures branch from 798a13c to 6524af5 Compare May 8, 2025 10:46
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the lint-error-return-failures branch from 6524af5 to 8c63242 Compare May 8, 2025 11:02

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit 8b549f8 into oras-project:main May 12, 2025
8 checks passed
qweeah pushed a commit to qweeah/oras that referenced this pull request May 13, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou pushed a commit to FeynmanZhou/oras that referenced this pull request May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants