fix: calls to close in tests unchecked for lint#1678
Merged
TerryHowe merged 3 commits intoMay 12, 2025
Conversation
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
==========================================
+ Coverage 84.88% 84.92% +0.03%
==========================================
Files 128 128
Lines 5751 5751
==========================================
+ Hits 4882 4884 +2
+ Misses 619 617 -2
Partials 250 250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Wwwsylvia
reviewed
Apr 1, 2025
Wwwsylvia
approved these changes
May 12, 2025
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
May 13, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
This was referenced Aug 7, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ignore some error returns for tests to fix newer lint.