refactor: move different targets to different files#1722
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1722 +/- ##
==========================================
- Coverage 84.84% 84.81% -0.04%
==========================================
Files 127 128 +1
Lines 5722 5722
==========================================
- Hits 4855 4853 -2
- Misses 617 619 +2
Partials 250 250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
qweeah
reviewed
May 12, 2025
qweeah
approved these changes
May 12, 2025
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestion.
qweeah
pushed a commit
to qweeah/oras
that referenced
this pull request
May 13, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com> Signed-off-by: Billy Zha <jinzha1@microsoft.com>
FeynmanZhou
pushed a commit
to FeynmanZhou/oras
that referenced
this pull request
May 28, 2025
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
This was referenced Aug 7, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Working on backup/restore I found the target object a bit rigid and I need to make some changes. Some non-controversial clean-up (I hope) should make that easier to review.