Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Well, I'm surprised. |
28c2b6c to
6983ccd
Compare
|
LGTM |
8fa2bb3 to
a341f97
Compare
|
Hmm, updating to docker 23.0.0 apparently doesn't result in API calls getting BuildKit by default after all. It must be a client default that changed. |
|
@flouthoc WDYT? |
Is this a recent change in docker 23.0.0 ? the PR LGTM. @nalind I think this already includes the needed change which I added here #246 hence closing #246 |
a341f97 to
a2398cf
Compare
It's the first item called out in the "New" section in https://docs.docker.com/engine/release-notes/23.0/. |
|
Since the tests pass is this ready to merge? |
a2398cf to
f37fca8
Compare
It was testing using a private fork of go-dockerclient to let the client request that the pair of cases that were failing be built using BuildKit instead, and I don't want us depending on my fork. Now that fsouza/go-dockerclient#961 is merged, we can avoid having to do that. /retitle Bump to Go 1.19 |
|
Also if anyone wants to approve openshift/release#36040, it's sure to save us some trouble later. |
Use Go 1.19 instead of 1.16 in go.mod. Test with 1.19/1.20 in Travis instead of 1.17/1.18. Bump the Travis environment from the default (16.04) to jammy (22.04), which is the latest currently available in Travis. Update assorted direct dependencies. Update conformance tests nonroot-USER-before-WORKDIR-notused and nonroot-USER-before-WORKDIR-used to request that they be built with BuildKit. Many conformance tests fail if we make this the default; we'll have to make that change and fix those later. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
f37fca8 to
91b1f3e
Compare
|
@nalind: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
LGTM |
|
A reminder that this repository has a bot to handle merges. |
Use Go 1.19 instead of 1.16 in go.mod.
Test with 1.19/1.20 in Travis instead of 1.17/1.18. Bump the Travis environment from the default (16.04) to jammy (22.04), which is the latest currently available in Travis.
Update assorted direct dependencies.
Obsoletes #241.
Update conformance tests nonroot-USER-before-WORKDIR-notused and nonroot-USER-before-WORKDIR-used to request that they be built with BuildKit. Many conformance tests fail if we make this the default; we'll have to make that change and fix those later.