Skip to content

Make conformance tests work on travis#241

Closed
saschagrunert wants to merge 1 commit intoopenshift:masterfrom
saschagrunert:conformance-tests
Closed

Make conformance tests work on travis#241
saschagrunert wants to merge 1 commit intoopenshift:masterfrom
saschagrunert:conformance-tests

Conversation

@saschagrunert
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert commented Jan 20, 2023 •
edited
Loading

This makes travis at least succeed on master again.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saschagrunert
Once this PR has been reviewed and has the lgtm label, please assign nalind for approval by writing /assign @nalind in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert changed the title Fix conformance tests WIP: Fix conformance tests Jan 20, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@saschagrunert saschagrunert force-pushed the conformance-tests branch 5 times, most recently from 77ef056 to bba2723 Compare January 23, 2023 11:27
@saschagrunert saschagrunert changed the title WIP: Fix conformance tests Make conformance tests work on travis Jan 23, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2023
@saschagrunert
Make conformance tests work on travis
ff54e84 
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 23, 2023

@saschagrunert: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nalind nalind mentioned this pull request Feb 6, 2023
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2023
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Feb 8, 2023

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Copy Markdown
Contributor

rhatdan commented Feb 8, 2023

@saschagrunert needs a rebase. Or to be deleted.

@saschagrunert
Copy link
Copy Markdown
Member Author

saschagrunert commented Feb 9, 2023

Can be closed now

@saschagrunert saschagrunert deleted the conformance-tests branch February 9, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

Assignees

No one assigned

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @openshift-merge-robot @rhatdan