Skip to content

imagebuilder: run unit tests with Go 1.19 instead of 1.18#36040

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
nalind:imagebuilder-with-go-1.19
Feb 8, 2023
Merged

imagebuilder: run unit tests with Go 1.19 instead of 1.18#36040
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
nalind:imagebuilder-with-go-1.19

Conversation

@nalind
Copy link
Copy Markdown
Member

@nalind nalind commented Feb 3, 2023

Go 1.20 was just released, so 1.18 is no longer maintained.

@nalind
imagebuilder: run unit tests with Go 1.19 instead of 1.18
891b7d5 
Go 1.20 was just released, so 1.18 is no longer maintained.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 3, 2023

@nalind: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-imagebuilder-master-unit openshift/imagebuilder presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@nalind
Copy link
Copy Markdown
Member Author

nalind commented Feb 3, 2023

/pj-rehearse

@nalind nalind mentioned this pull request Feb 6, 2023
Merged
flouthoc
flouthoc approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nalind
Copy link
Copy Markdown
Member Author

nalind commented Feb 8, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit 992fcec into openshift:master Feb 8, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 8, 2023

@nalind: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-imagebuilder-master.yaml using file ci-operator/config/openshift/imagebuilder/openshift-imagebuilder-master.yaml
Details

In response to this:

Go 1.20 was just released, so 1.18 is no longer maintained.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nalind nalind deleted the imagebuilder-with-go-1.19 branch February 8, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@TomSweeneyRedHat TomSweeneyRedHat Awaiting requested review from TomSweeneyRedHat

1 more reviewer

@flouthoc flouthoc flouthoc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@flouthoc flouthoc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nalind @openshift-ci-robot @flouthoc @openshift-merge-robot