Add the Version field to BuildImageOptions#961
Merged
fsouza merged 1 commit intofsouza:mainfrom Feb 7, 2023
Merged
Conversation
The `Version` field was added in API 1.39, though at the time the only
known value was "1" ("classic" docker build). API 1.42 added "2" to
identify the newer BuildKit-based builder.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
fsouza
reviewed
Feb 7, 2023
| type BuilderVersion string | ||
|
|
||
| const ( | ||
| BuilderV1 BuilderVersion = "1" |
Contributor
Author
There was a problem hiding this comment.
The client SDK (here) calls it BuilderV1, but I've no real preference. Should I change it?
Owner
There was a problem hiding this comment.
Let's keep it V1 then. Thanks for checking!
Contributor
Author
|
Thanks for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Versionfield was added in API 1.39, though at the time the only known value was "1" ("classic" docker build). API 1.42 added "2" to identify the newer BuildKit-based builder.We don't bump the requested API version to 1.42 when we're passed "2", but we could, though I suspect that it was accepted but undocumented for some versions in between.