OCPCLOUD-2215,OCPBUGS-17289,OCPBUGS-21650: Merge https://github.com/kubernetes-sigs/cluster-api-operator:v0.6.0 (a8f5386) into main#25
Conversation
🌱 Update helm chart index.yaml
🌱 Enable nestif linter again
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.1 to 1.53.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.50.1...v1.53.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/hack/chart-update/google.golang.org/grpc-1.53.0 🌱 build(deps): bump google.golang.org/grpc from 1.50.1 to 1.53.0 in /hack/chart-update
✨Fetch latest provider version if it's not set in the spec
To work properly CAPI Operator needs cert-manager. To ensure it is installed, we add a cert-manager dependency to the helm chart.
Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.9.0 to 0.10.0. - [Commits](golang/oauth2@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…t/go_modules/golang.org/x/oauth2-0.10.0 🌱 bump golang.org/x/oauth2 from 0.9.0 to 0.10.0
✨ Add cert-manager as a dependency to helm-chart
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
✨Bump go version to v1.20.4
Now we compile it twice, which seems unnecessary.
🌱 compile capi operator binary only once in the Dockerfile
🌱 Bump Cluster API to v1.5.0-rc.0
✨ Create operator CRs based on helm values
d3a6506 to
b4d1583
Compare
|
@damdo: This pull request references OCPCLOUD-2215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. This pull request references Jira Issue OCPBUGS-17286, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: This pull request references OCPCLOUD-2215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: This pull request references OCPCLOUD-2215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. This pull request references Jira Issue OCPBUGS-17289, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: This pull request references OCPCLOUD-2215 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set. This pull request references Jira Issue OCPBUGS-17289, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-21650, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@damdo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm /hold I would like to see a cluster-bot test to verify that this does indeed work with the paired PR as expected. If we can get green results from cluster bot then I think a green button merge to merge them simultaneously should be safe |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
@damdo: Jira Issue OCPBUGS-17289: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-17289 has been moved to the MODIFIED state. Jira Issue OCPBUGS-21650: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-21650 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.15.0-0.nightly-2023-10-24-230302 |
Warning
This PR needs to be "GREEN BUTTON MERGED" at the same time as the cluster-capi-operator [PR](https://github.com/openshift/cluster-api-operator/pull/25), as the new code of this operator references a new CRD (deployed by the other repo), so to avoid breaking the payload we need to merge them together. (We are planning to fix this, see enhancement)