Skip to content

✨Bump go version to v1.20.4#187

Merged
k8s-ci-robot merged 4 commits into
kubernetes-sigs:mainfrom
furkatgofurov7:bump-go-1.20
Jul 13, 2023
Merged

✨Bump go version to v1.20.4#187
k8s-ci-robot merged 4 commits into
kubernetes-sigs:mainfrom
furkatgofurov7:bump-go-1.20

Conversation

@furkatgofurov7

@furkatgofurov7 furkatgofurov7 commented Jul 13, 2023

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Few CI jobs are failing in main branch (e2e-main, test-main) and PRs like #186 due to go version incompatibility with k8s:

Activated service account credentials for: [prow-build@k8s-infra-prow-build.iam.gserviceaccount.com]
+ WRAPPED_COMMAND_PID=[2](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/186/pull-cluster-api-operator-test-main/1679273348103671808#1:build-log.txt%3A2)7
+ wait 27
+ ./scripts/ci-test.sh
Detected go version: go version go1.19.10 linux/amd6[4](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-operator/186/pull-cluster-api-operator-test-main/1679273348103671808#1:build-log.txt%3A4).
Kubernetes requires go1.20.0 or greater.
Please install go1.20.0 or later.
+ EXIT_VALUE=2
+ set +o xtrace

This PR bumps go version (1st commit), fixes lint issue (2nd commit) and also allows users to override the builder image (3rd commit)

@furkatgofurov7
Bump go to v1.20.4
e0d0fd9 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 13, 2023
@furkatgofurov7

furkatgofurov7 commented Jul 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

hmm #186 already does take care of the go bump, I will rebase this once that is merged

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@Fedosin

Fedosin commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

/retest

Fedosin
Fedosin reviewed Jul 13, 2023
View reviewed changes
Comment thread cmd/main.go Outdated
@Fedosin Fedosin mentioned this pull request Jul 13, 2023
Merged
@furkatgofurov7
Fix golint issue after go bump
1efedec 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Add --build-arg to override builder image
89e8fdc 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Fix ci-verify.sh echo message
f9480e2
@furkatgofurov7

furkatgofurov7 commented Jul 13, 2023

Copy link
Copy Markdown
Member Author

/hold cancel

/cc @alexander-demicev @Fedosin @damdo

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from Fedosin and damdo July 13, 2023 13:34
alexander-demicev
alexander-demicev approved these changes Jul 13, 2023
View reviewed changes

@alexander-demicev alexander-demicev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/approve

@k8s-ci-robot

k8s-ci-robot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
Fedosin
Fedosin approved these changes Jul 13, 2023
View reviewed changes

@Fedosin Fedosin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot

k8s-ci-robot commented Jul 13, 2023

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 876e68fbb28a891a58963fedacda378a1150403d

@k8s-ci-robot k8s-ci-robot merged commit f55e815 into kubernetes-sigs:main Jul 13, 2023
@furkatgofurov7 furkatgofurov7 deleted the bump-go-1.20 branch July 13, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fedosin Fedosin Fedosin approved these changes

@alexander-demicev alexander-demicev alexander-demicev approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@neolit123 neolit123 Awaiting requested review from neolit123

@damdo damdo Awaiting requested review from damdo

Assignees

@Fedosin Fedosin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@furkatgofurov7 @Fedosin @k8s-ci-robot @alexander-demicev