Skip to content

🌱 Enable nestif linter again#182

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Fedosin:enable_nestif_linter
Jul 3, 2023
Merged

🌱 Enable nestif linter again#182
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
Fedosin:enable_nestif_linter

Conversation

@Fedosin

@Fedosin Fedosin commented Jul 1, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

We temporarily disabled this linter, so it's time to enable it again.
This PR fixes issues reported by the linter. Additionally it verifies that "manager" container exists in provider deployment, and if it doesn't - operator reports an error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot requested review from damdo and timothysc July 1, 2023 15:24
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 1, 2023
@Fedosin Fedosin changed the title chore: enable nestif linter again 🌱 Enable nestif linter again Jul 1, 2023

@damdo damdo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2023
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: beee5b4c07d36fc046b7d414355e806a063fb561

@furkatgofurov7 furkatgofurov7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 99a8c4c into kubernetes-sigs:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants